[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #38985: [SPARK-41451][K8S] Avoid using empty abbrevMarker in StringUtils.abbreviate

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on code in PR #38985:
URL: https://github.com/apache/spark/pull/38985#discussion_r1043866184


##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesConf.scala:
##########
@@ -275,7 +275,7 @@ private[spark] object KubernetesConf {
         .toLowerCase(Locale.ROOT)
         .replaceAll("[^a-z0-9\\-]", "-")
         .replaceAll("-+", "-"),
-      "",
+      "-", // avoid using empty string, see https://issues.apache.org/jira/browse/LANG-1463

Review Comment:
   It's a little confusing that LANG-1463 is marked as fixed at 3.10 and Apache Spark is using 3.12.
   If LANG-1463 is not fixed yet, please mention correctly instead of saying `see ...`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org