You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by GitBox <gi...@apache.org> on 2020/05/24 11:32:15 UTC
[GitHub] [wicket] theigl opened a new pull request #433: WICKET-6788 Improve performance of markup escaping
theigl opened a new pull request #433:
URL: https://github.com/apache/wicket/pull/433
Checks for `Character.UNASSIGNED` instead of looking up non-chars in a set.
This solution more than doubles the throughput:
```
escapeMarkupHashSet thrpt 5 395348,174 ± 48047,375 ops/s
escapeMarkupCharacterType thrpt 5 847227,062 ± 13051,584 ops/s
```
https://issues.apache.org/jira/browse/WICKET-6788
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [wicket] martin-g commented on pull request #433: WICKET-6788 Improve performance of markup escaping
Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #433:
URL: https://github.com/apache/wicket/pull/433#issuecomment-633436683
@theigl You need to link your GitHub account with your Apache account at https://gitbox.apache.org/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [wicket] theigl commented on pull request #433: WICKET-6788 Improve performance of markup escaping
Posted by GitBox <gi...@apache.org>.
theigl commented on pull request #433:
URL: https://github.com/apache/wicket/pull/433#issuecomment-633452505
@martin-g: Thanks for the hint!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [wicket] theigl commented on pull request #433: WICKET-6788 Improve performance of markup escaping
Posted by GitBox <gi...@apache.org>.
theigl commented on pull request #433:
URL: https://github.com/apache/wicket/pull/433#issuecomment-633430131
Thanks for the reviews! Can somebody please merge this? I don't seem to have write access yet.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [wicket] theigl merged pull request #433: WICKET-6788 Improve performance of markup escaping
Posted by GitBox <gi...@apache.org>.
theigl merged pull request #433:
URL: https://github.com/apache/wicket/pull/433
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org