You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/06/09 22:03:53 UTC

[GitHub] [nifi] exceptionfactory opened a new pull request, #6114: NIFI-10096 Correct nested inherited Parameter Context loading

exceptionfactory opened a new pull request, #6114:
URL: https://github.com/apache/nifi/pull/6114

   # Summary
   
   [NIFI-10096](https://issues.apache.org/jira/browse/NIFI-10096) Corrects loading of inherited Parameter Contexts to avoiding warnings and missing inherited Parameter Context references.
   
   Based on the order of persisted Parameter Contexts, NiFi can load a child context before a parent context, resulting in warnings and missing Parameter Context inheritance references. Building and referencing a map of available Parameter Context names to available Parameter Contexts allows the `VersionedFlowSynchronizer` to locate inherited Parameter Contexts regardless of persisted order.
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
   
   ### Pull Request Tracking
   
   - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
   - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
   
   ### Pull Request Formatting
   
   - [X] Pull Request based on current revision of the `main` branch
   - [X] Pull Request refers to a feature branch with one commit containing changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request creation.
   
   ### Build
   
   - [X] Build completed using `mvn clean install -P contrib-check`
     - [X] JDK 8
     - [ ] JDK 11
     - [ ] JDK 17
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] joewitt commented on pull request #6114: NIFI-10096 Correct nested inherited Parameter Context loading

Posted by GitBox <gi...@apache.org>.
joewitt commented on PR #6114:
URL: https://github.com/apache/nifi/pull/6114#issuecomment-1151669518

   @exceptionfactory so gist is we need to load all param contexts found then lookup referenced ones so that we dont attempt to reference something before it has been loaded?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] exceptionfactory commented on pull request #6114: NIFI-10096 Correct nested inherited Parameter Context loading

Posted by GitBox <gi...@apache.org>.
exceptionfactory commented on PR #6114:
URL: https://github.com/apache/nifi/pull/6114#issuecomment-1151684396

   @joewitt Yes, prior to this PR, the `findReferencedParameterContextIds` method relied on the `ParameterContextManager` as the only source of inherited parameter contexts.
   
   Since NiFi can load Child Context B before Parent Context A, the method would log a warning.
   
   The changes implemented construct a map of available context names from the Versioned Flow so that the references are available regardless of when they are added to the `ParameterContextManager`. Processing further on ensures that all referenced Parameter Contexts are loaded, so these changes preserve the intent of the `FlowManager.withParameterContextResolution` method.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] asfgit closed pull request #6114: NIFI-10096 Correct nested inherited Parameter Context loading

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #6114: NIFI-10096 Correct nested inherited Parameter Context loading
URL: https://github.com/apache/nifi/pull/6114


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org