You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by GitBox <gi...@apache.org> on 2022/11/28 12:46:19 UTC
[GitHub] [myfaces] pnicolucci opened a new pull request, #399: MYFACES-4503: use ELManager.getExpressionFactory()
pnicolucci opened a new pull request, #399:
URL: https://github.com/apache/myfaces/pull/399
https://issues.apache.org/jira/browse/MYFACES-4503
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] tandraschko commented on pull request #399: MYFACES-4503: use ELManager.getExpressionFactory()
Posted by GitBox <gi...@apache.org>.
tandraschko commented on PR #399:
URL: https://github.com/apache/myfaces/pull/399#issuecomment-1329105438
all right, then +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] pnicolucci merged pull request #399: MYFACES-4503: use ELManager.getExpressionFactory()
Posted by GitBox <gi...@apache.org>.
pnicolucci merged PR #399:
URL: https://github.com/apache/myfaces/pull/399
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] tandraschko commented on pull request #399: MYFACES-4503: use ELManager.getExpressionFactory()
Posted by GitBox <gi...@apache.org>.
tandraschko commented on PR #399:
URL: https://github.com/apache/myfaces/pull/399#issuecomment-1329032734
should we leave the old lookup as fallback if ELManager returns null?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] pnicolucci commented on pull request #399: MYFACES-4503: use ELManager.getExpressionFactory()
Posted by GitBox <gi...@apache.org>.
pnicolucci commented on PR #399:
URL: https://github.com/apache/myfaces/pull/399#issuecomment-1329101260
> should we leave the old lookup as fallback if ELManager returns null?
@tandraschko I'd prefer not to unless we find that it is necessary this keeps the code clean IMO. Looking at the ELManager Java Doc: https://jakarta.ee/specifications/expression-language/5.0/apidocs/jakarta.el/jakarta/el/elmanager#getExpressionFactory() and the Tomcat implementation for example https://github.com/apache/tomcat/blob/main/java/jakarta/el/Util.java#L97 I think we'll always get an instance back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org