You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by ji...@apache.org on 2019/09/23 06:00:09 UTC
[incubator-weex] branch master updated: [iOS] Remove 'Too many
timers' report. (#2930)
This is an automated email from the ASF dual-hosted git repository.
jianhan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-weex.git
The following commit(s) were added to refs/heads/master by this push:
new e8f323a [iOS] Remove 'Too many timers' report. (#2930)
e8f323a is described below
commit e8f323a00ad031727074739866200fd337f93529
Author: wqyfavor <qi...@alibaba-inc.com>
AuthorDate: Mon Sep 23 14:00:03 2019 +0800
[iOS] Remove 'Too many timers' report. (#2930)
* [iOS] Remove 'Too many timers' report.
* [iOS] Remove 'Too many timers' report.
---
ios/sdk/WeexSDK/Sources/Engine/WXSDKError.h | 1 -
ios/sdk/WeexSDK/Sources/Engine/WXSDKError.m | 1 -
ios/sdk/WeexSDK/Sources/Module/WXTimerModule.m | 9 ---------
3 files changed, 11 deletions(-)
diff --git a/ios/sdk/WeexSDK/Sources/Engine/WXSDKError.h b/ios/sdk/WeexSDK/Sources/Engine/WXSDKError.h
index b628b06..449ab92 100644
--- a/ios/sdk/WeexSDK/Sources/Engine/WXSDKError.h
+++ b/ios/sdk/WeexSDK/Sources/Engine/WXSDKError.h
@@ -106,7 +106,6 @@ typedef NS_ENUM(int, WXSDKErrCode)
WX_KEY_EXCEPTION_EMPTY_SCREEN_JS = -9700,
WX_KEY_EXCEPTION_EMPTY_SCREEN_NATIVE = -9701,
- WX_KEY_EXCEPTION_TOO_MANY_TIMERS = -9800,
WX_KEY_EXCEPTION_NO_BUNDLE_TYPE = -9801,
WX_KEY_EXCEPTION_HERON_ERROR = -9900,
diff --git a/ios/sdk/WeexSDK/Sources/Engine/WXSDKError.m b/ios/sdk/WeexSDK/Sources/Engine/WXSDKError.m
index 07ccbe1..8d7bc9d 100644
--- a/ios/sdk/WeexSDK/Sources/Engine/WXSDKError.m
+++ b/ios/sdk/WeexSDK/Sources/Engine/WXSDKError.m
@@ -103,7 +103,6 @@
@(WX_KEY_EXCEPTION_EMPTY_SCREEN_JS):@{ERROR_TYPE:@(WX_RENDER_ERROR),ERROR_GROUP:@(WX_JS)},
@(WX_KEY_EXCEPTION_EMPTY_SCREEN_NATIVE):@{ERROR_TYPE:@(WX_RENDER_ERROR),ERROR_GROUP:@(WX_NATIVE)},
- @(WX_KEY_EXCEPTION_TOO_MANY_TIMERS):@{ERROR_TYPE:@(WX_NATIVE_ERROR),ERROR_GROUP:@(WX_NATIVE)},
@(WX_KEY_EXCEPTION_NO_BUNDLE_TYPE):@{ERROR_TYPE:@(WX_JS_ERROR),ERROR_GROUP:@(WX_JS)},
@(WX_KEY_EXCEPTION_HERON_ERROR):@{ERROR_TYPE:@(WX_NATIVE_ERROR),ERROR_GROUP:@(WX_NATIVE)},
diff --git a/ios/sdk/WeexSDK/Sources/Module/WXTimerModule.m b/ios/sdk/WeexSDK/Sources/Module/WXTimerModule.m
index e6c158f..d036409 100644
--- a/ios/sdk/WeexSDK/Sources/Module/WXTimerModule.m
+++ b/ios/sdk/WeexSDK/Sources/Module/WXTimerModule.m
@@ -77,7 +77,6 @@
@implementation WXTimerModule
{
- BOOL _tooManyTimersReported;
NSMutableDictionary *_timers;
}
@@ -178,14 +177,6 @@ WX_EXPORT_METHOD(@selector(clearInterval:))
}
}
[_timers removeObjectsForKeys:invalidTimerIds];
-
- // If alive timer count still exceeds 30, we report once for this page.
- if ([_timers count] > 30) {
- if (!_tooManyTimersReported) {
- [WXExceptionUtils commitCriticalExceptionRT:self.weexInstance.instanceId errCode:[NSString stringWithFormat:@"%d", WX_KEY_EXCEPTION_TOO_MANY_TIMERS] function:@"" exception:@"Too many timers." extParams:nil];
- _tooManyTimersReported = YES;
- }
- }
}
}
}