You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by co...@apache.org on 2025/06/26 13:36:47 UTC
(seatunnel) branch dev updated: [Chore][Core] Remove useless parameter in ConfigBuilder (#9494)
This is an automated email from the ASF dual-hosted git repository.
corgy pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/seatunnel.git
The following commit(s) were added to refs/heads/dev by this push:
new 79157142a5 [Chore][Core] Remove useless parameter in ConfigBuilder (#9494)
79157142a5 is described below
commit 79157142a59d4ad72d53d5d4dc5e432afaf71697
Author: Jia Fan <fa...@qq.com>
AuthorDate: Thu Jun 26 21:36:42 2025 +0800
[Chore][Core] Remove useless parameter in ConfigBuilder (#9494)
---
.../java/org/apache/seatunnel/core/starter/utils/ConfigBuilder.java | 5 ++---
.../java/org/apache/seatunnel/e2e/common/util/ConfigBuilder.java | 4 ----
.../main/java/org/apache/seatunnel/engine/server/utils/RestUtil.java | 4 ++--
3 files changed, 4 insertions(+), 9 deletions(-)
diff --git a/seatunnel-core/seatunnel-core-starter/src/main/java/org/apache/seatunnel/core/starter/utils/ConfigBuilder.java b/seatunnel-core/seatunnel-core-starter/src/main/java/org/apache/seatunnel/core/starter/utils/ConfigBuilder.java
index 56c4ff4b96..b629913fa0 100644
--- a/seatunnel-core/seatunnel-core-starter/src/main/java/org/apache/seatunnel/core/starter/utils/ConfigBuilder.java
+++ b/seatunnel-core/seatunnel-core-starter/src/main/java/org/apache/seatunnel/core/starter/utils/ConfigBuilder.java
@@ -100,11 +100,10 @@ public class ConfigBuilder {
}
public static Config of(@NonNull Map<String, Object> objectMap) {
- return of(objectMap, false, false);
+ return of(objectMap, false);
}
- public static Config of(
- @NonNull Map<String, Object> objectMap, boolean isEncrypt, boolean isJson) {
+ public static Config of(@NonNull Map<String, Object> objectMap, boolean isEncrypt) {
log.info("Loading config file from objectMap");
Config config =
ConfigFactory.parseMap(objectMap)
diff --git a/seatunnel-e2e/seatunnel-e2e-common/src/test/java/org/apache/seatunnel/e2e/common/util/ConfigBuilder.java b/seatunnel-e2e/seatunnel-e2e-common/src/test/java/org/apache/seatunnel/e2e/common/util/ConfigBuilder.java
index f50c900b41..6e6312b5a5 100644
--- a/seatunnel-e2e/seatunnel-e2e-common/src/test/java/org/apache/seatunnel/e2e/common/util/ConfigBuilder.java
+++ b/seatunnel-e2e/seatunnel-e2e-common/src/test/java/org/apache/seatunnel/e2e/common/util/ConfigBuilder.java
@@ -69,10 +69,6 @@ public class ConfigBuilder {
}
public static Config of(@NonNull Map<String, Object> objectMap) {
- return of(objectMap, false);
- }
-
- public static Config of(@NonNull Map<String, Object> objectMap, boolean isEncrypt) {
log.info("Loading config file from objectMap");
Config config =
ConfigFactory.parseMap(objectMap)
diff --git a/seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/utils/RestUtil.java b/seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/utils/RestUtil.java
index b114073aad..ee91f5a962 100644
--- a/seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/utils/RestUtil.java
+++ b/seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/utils/RestUtil.java
@@ -73,7 +73,7 @@ public class RestUtil {
public static Config buildConfig(JsonNode jsonNode, boolean isEncrypt) {
Map<String, Object> objectMap = JsonUtils.toMap(jsonNode);
- return ConfigBuilder.of(objectMap, isEncrypt, true);
+ return ConfigBuilder.of(objectMap, isEncrypt);
}
public static List<Tuple2<Map<String, String>, Config>> buildConfigList(
@@ -85,7 +85,7 @@ public class RestUtil {
Map<String, Object> nodeMap = JsonUtils.toMap(node);
Map<String, String> params =
(Map<String, String>) nodeMap.remove(REST_SUBMIT_JOBS_PARAMS);
- Config config = ConfigBuilder.of(nodeMap, isEncrypt, true);
+ Config config = ConfigBuilder.of(nodeMap, isEncrypt);
return new Tuple2<>(params, config);
})
.collect(Collectors.toList());