You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jorisvandenbossche (via GitHub)" <gi...@apache.org> on 2024/04/22 19:30:45 UTC
[PR] feat(python): add back nanoarrow.array(..) constructor [arrow-nanoarrow]
jorisvandenbossche opened a new pull request, #441:
URL: https://github.com/apache/arrow-nanoarrow/pull/441
Closes https://github.com/apache/arrow-nanoarrow/issues/434
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(python): add back nanoarrow.array(..) constructor [arrow-nanoarrow]
Posted by "jorisvandenbossche (via GitHub)" <gi...@apache.org>.
jorisvandenbossche merged PR #441:
URL: https://github.com/apache/arrow-nanoarrow/pull/441
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(python): add back nanoarrow.array(..) constructor [arrow-nanoarrow]
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on code in PR #441:
URL: https://github.com/apache/arrow-nanoarrow/pull/441#discussion_r1576466948
##########
python/tests/test_array.py:
##########
@@ -38,6 +38,11 @@ def test_array_construct():
iter(array)
+def test_array_constructor():
+ array = na.Array([1, 2, 3], na.int32())
Review Comment:
```suggestion
array = na.array([1, 2, 3], na.int32())
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(python): add back nanoarrow.array(..) constructor [arrow-nanoarrow]
Posted by "jorisvandenbossche (via GitHub)" <gi...@apache.org>.
jorisvandenbossche commented on code in PR #441:
URL: https://github.com/apache/arrow-nanoarrow/pull/441#discussion_r1576537273
##########
python/tests/test_array.py:
##########
@@ -38,6 +38,11 @@ def test_array_construct():
iter(array)
+def test_array_constructor():
+ array = na.Array([1, 2, 3], na.int32())
Review Comment:
whoops ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org