[jira] [Comment Edited] (HAMA-774) CompositeInputFormat in Hama

["Martin Illecker (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HAMA-774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13836403#comment-13836403 ] 

Martin Illecker edited comment on HAMA-774 at 12/2/13 10:14 AM:
----------------------------------------------------------------

It's not possible to move TupleWritable from o.a.h.bsp.join to o.a.h.commons.io because it has some methods (setWritten, clearWritten) with no modifier in it. (visible only in class and package) These methods are used by o.a.h.bsp.join.CompositeRecordReader. 
One way would be to increase the visibility of these methods to public, but in our discussion in HAMA-699, we agreed to keep classes together and don't split them. 
So therefore we would have to move the whole o.a.h.bsp.join package to commons and it's dependencies: 
(o.a.h.HamaConfiguration; o.a.h.bsp.BSPJob; o.a.h.bsp.FileInputFormat; o.a.h.bsp.InputFormat; o.a.h.bsp.InputSplit; o.a.h.bsp.RecordReader;)



was (Author: bafu):
It's not possible to move TupleWritable from o.a.h.bsp.join to o.a.h.commons.io because it has some methods (setWritten, clearWritten) with no modifier in it. (visible only in class and package)
These methods are used by o.a.h.bsp.join.CompositeRecordReader. 
One way would be to increase the visibility of these methods to public, but in our discussion in HAMA-699, we agreed to keep classes together and don't split them. 
So therefore we would have to move the whole o.a.h.bsp.join package to commons and it's dependencies: 
(o.a.h.HamaConfiguration; o.a.h.bsp.BSPJob; o.a.h.bsp.FileInputFormat; o.a.h.bsp.InputFormat; o.a.h.bsp.InputSplit; o.a.h.bsp.RecordReader;)


> CompositeInputFormat in Hama
> ----------------------------
>
>                 Key: HAMA-774
>                 URL: https://issues.apache.org/jira/browse/HAMA-774
>             Project: Hama
>          Issue Type: New Feature
>          Components: bsp core
>    Affects Versions: 0.6.2
>            Reporter: Martin Illecker
>            Assignee: Martin Illecker
>            Priority: Minor
>             Fix For: 0.7.0
>
>         Attachments: HAMA-774.patch, HAMA-774_v02.patch
>
>
> *Adapting Hadoop CompositeInputFormat to Hama.*
> Adapt the CompositeInputFormat from Hadoop and integrate it into Hama.
> e.g., Useful for matrix multiplication example by doing a inner join of two matrices.
> Therefore the Hadoop join package has been adapted within *org.apache.hama.bsp.join*.
> Finally I would need some help to integrate the CompositeInputFormat into Hama by using
> {code} 
> job.setInputFormat(CompositeInputFormat.class);
> job.set("bsp.join.expr", CompositeInputFormat.compose("inner",
>    SequenceFileInputFormat.class, aPath, bPath));
> {code}



--
This message was sent by Atlassian JIRA
(v6.1#6144)