You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/08/27 17:22:41 UTC

[GitHub] [incubator-mxnet] Zha0q1 commented on a change in pull request #19025: Numpy pick large tensor fix

Zha0q1 commented on a change in pull request #19025:
URL: https://github.com/apache/incubator-mxnet/pull/19025#discussion_r478577604



##########
File path: tests/nightly/test_np_large_array.py
##########
@@ -696,16 +696,16 @@ def test_one_hot():
     assert A.grad[0] == 0
 
 @use_np
-@pytest.mark.skip(reason='backward value broken on large tensor')
 def test_pick():
     A = np.zeros((INT_OVERFLOW, 2))
     B = np.zeros((INT_OVERFLOW))
+    A[0, 0] = 3

Review comment:
       sure I can also check the value of a large index.
   However because https://github.com/apache/incubator-mxnet/issues/19014 this issue (assigment operator bug) we cannot modify the value of a large index




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org