You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Murali Reddy <mu...@gmail.com> on 2013/06/04 07:47:27 UTC

Re: Review Request: Updated account and domain id for nic secondary ips for shared networks

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11458/#review21409
-----------------------------------------------------------


Should set the owner to be entity owner passed as ipowner instead of caller.

- Murali Reddy


On May 28, 2013, 7:27 a.m., Jayapal Reddy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11458/
> -----------------------------------------------------------
> 
> (Updated May 28, 2013, 7:27 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Murali Reddy.
> 
> 
> Description
> -------
> 
> Updated account and domain id for nic secondary ips for shared networks.
> Fixed by getting accoundId and domainId from the caller instead of network
> 
> 
> This addresses bug CLOUDSTACK-2609.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/network/NetworkServiceImpl.java f880bcc 
> 
> Diff: https://reviews.apache.org/r/11458/diff/
> 
> 
> Testing
> -------
> 
> Tested on isolated and shared networks.
> 
> 
> Thanks,
> 
> Jayapal Reddy
> 
>


Re: Review Request: Updated account and domain id for nic secondary ips for shared networks

Posted by Jayapal Reddy <ja...@citrix.com>.

> On June 4, 2013, 5:47 a.m., Murali Reddy wrote:
> > Should set the owner to be entity owner passed as ipowner instead of caller.

Updated to ipOwner


- Jayapal


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11458/#review21409
-----------------------------------------------------------


On May 28, 2013, 7:27 a.m., Jayapal Reddy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11458/
> -----------------------------------------------------------
> 
> (Updated May 28, 2013, 7:27 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Murali Reddy.
> 
> 
> Description
> -------
> 
> Updated account and domain id for nic secondary ips for shared networks.
> Fixed by getting accoundId and domainId from the caller instead of network
> 
> 
> This addresses bug CLOUDSTACK-2609.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/network/NetworkServiceImpl.java f880bcc 
> 
> Diff: https://reviews.apache.org/r/11458/diff/
> 
> 
> Testing
> -------
> 
> Tested on isolated and shared networks.
> 
> 
> Thanks,
> 
> Jayapal Reddy
> 
>