You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by zjffdu <gi...@git.apache.org> on 2017/02/22 12:02:10 UTC
[GitHub] zeppelin pull request #2056: ZEPPELIN-2151. Add integration test for livy ca...
GitHub user zjffdu opened a pull request:
https://github.com/apache/zeppelin/pull/2056
ZEPPELIN-2151. Add integration test for livy cancel api
### What is this PR for?
Just add integration test for livy cancel api. Only do it for livy 0.3 as the cancel api is only available in livy 0.3
### What type of PR is it?
[ Improvement]
### Todos
* [ ] - Task
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-2151
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-2151
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2056.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2056
----
commit e8fc14987a3df9ba8c810997ae323be1f2aec1ff
Author: Jeff Zhang <zj...@apache.org>
Date: 2017-02-22T11:59:47Z
ZEPPELIN-2151. Add integration test for livy cancel api
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2056: ZEPPELIN-2151. Add integration test for livy ca...
Posted by zjffdu <gi...@git.apache.org>.
GitHub user zjffdu reopened a pull request:
https://github.com/apache/zeppelin/pull/2056
ZEPPELIN-2151. Add integration test for livy cancel api
### What is this PR for?
Just add integration test for livy cancel api. Only do it for livy 0.3 as the cancel api is only available in livy 0.3
### What type of PR is it?
[ Improvement]
### Todos
* [ ] - Task
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-2151
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-2151
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2056.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2056
----
commit e5fe4914879948e3981d104f296871a20e04977f
Author: Jeff Zhang <zj...@apache.org>
Date: 2017-02-22T11:59:47Z
ZEPPELIN-2151. Add integration test for livy cancel api
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2056: ZEPPELIN-2151. Add integration test for livy ca...
Posted by zjffdu <gi...@git.apache.org>.
GitHub user zjffdu reopened a pull request:
https://github.com/apache/zeppelin/pull/2056
ZEPPELIN-2151. Add integration test for livy cancel api
### What is this PR for?
Just add integration test for livy cancel api. Only do it for livy 0.3 as the cancel api is only available in livy 0.3
### What type of PR is it?
[ Improvement]
### Todos
* [ ] - Task
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-2151
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-2151
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2056.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2056
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2056: ZEPPELIN-2151. Add integration test for livy ca...
Posted by zjffdu <gi...@git.apache.org>.
GitHub user zjffdu reopened a pull request:
https://github.com/apache/zeppelin/pull/2056
ZEPPELIN-2151. Add integration test for livy cancel api
### What is this PR for?
Just add integration test for livy cancel api. Only do it for livy 0.3 as the cancel api is only available in livy 0.3
### What type of PR is it?
[ Improvement]
### Todos
* [ ] - Task
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-2151
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-2151
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2056.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2056
----
commit e5fe4914879948e3981d104f296871a20e04977f
Author: Jeff Zhang <zj...@apache.org>
Date: 2017-02-22T11:59:47Z
ZEPPELIN-2151. Add integration test for livy cancel api
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2056: ZEPPELIN-2151. Add integration test for livy ca...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu closed the pull request at:
https://github.com/apache/zeppelin/pull/2056
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2056: ZEPPELIN-2151. Add integration test for livy ca...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2056
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2056: ZEPPELIN-2151. Add integration test for livy cancel ap...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2056
looks good, hmm, but the livy 0.3 test is failing
https://travis-ci.org/zjffdu/zeppelin/builds/204166190
and you are saying it's not related to this? shall we kick it off one more time to see?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2056: ZEPPELIN-2151. Add integration test for livy cancel ap...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2056
one failure: https://travis-ci.org/zjffdu/zeppelin/jobs/204447551
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2056: ZEPPELIN-2151. Add integration test for livy cancel ap...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2056
CI continue fail in the same place. But this is not livy relevant, as I didn't change any code outside livy interpreter. I have created ticket ZEPPELIN-2155 for this
```
Failed tests:
NotebookTest.testPublicPrivateNewNote:1173 expected:<2C[B7YJQ16]> but was:<2C[A45Z6X7]>
NotebookTest.testAuthorizationRoles:759 expected:<false> but was:<true>
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2056: ZEPPELIN-2151. Add integration test for livy cancel ap...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2056
@felixcheung @prabhjyotsingh Please help review. CI failure is not relevant.
```
Failed tests:
NotebookTest.testPublicPrivateNewNote:1173 expected:<2C[A7GB62Y]> but was:<2C[8XKNFD4]>
NotebookTest.testAuthorizationRoles:759 expected:<false> but was:<true>
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2056: ZEPPELIN-2151. Add integration test for livy ca...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu closed the pull request at:
https://github.com/apache/zeppelin/pull/2056
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2056: ZEPPELIN-2151. Add integration test for livy cancel ap...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2056
ping @felixcheung CI is passed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2056: ZEPPELIN-2151. Add integration test for livy cancel ap...
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/2056
I also think those tests not related to this PR and can be handled in that separate issue, probably some resource note name was changed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2056: ZEPPELIN-2151. Add integration test for livy cancel ap...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2056
Even though test is not directly related to this PR
I have experienced some code change or additional test may break other test, because of resource consumption or other unexpected reason.
Once master branch CI fails, it'll impact all other pullrequest review/verification.
If it change is not super urgent, i suggest we first figure out CI problem and then merge this code after the fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2056: ZEPPELIN-2151. Add integration test for livy cancel ap...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2056
merged to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2056: ZEPPELIN-2151. Add integration test for livy ca...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu closed the pull request at:
https://github.com/apache/zeppelin/pull/2056
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2056: ZEPPELIN-2151. Add integration test for livy cancel ap...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2056
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---