You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Daniel Becker (Code Review)" <ge...@cloudera.org> on 2025/06/23 14:06:10 UTC

[Impala-ASF-CR] IMPALA-14161: Thrift SSL tests fail on Centos 7

Daniel Becker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23069


Change subject: IMPALA-14161: Thrift SSL tests fail on Centos 7
......................................................................

IMPALA-14161: Thrift SSL tests fail on Centos 7

After the rebase of the Kudu code in to v1.17.1 (see IMPALA-14066), some
backend tests in thrift-server-test.cc stopped working on CentOs 7.9.

This is because the list of available TLS ciphers has been updated in
Kudu commit https://gerrit.cloudera.org/#/c/17268/, which was picked up
in the rebase.

This commit fixes the tests by extending the cipher list that the tests
use with "AES256-GCM-SHA384". Note that this does not affect production
code.

Change-Id: I2ade7e7308c05baf640a6cbfd62d10f9689a5d9a
---
M be/src/rpc/thrift-server-test.cc
1 file changed, 31 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/69/23069/1
-- 
To view, visit http://gerrit.cloudera.org:8080/23069
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2ade7e7308c05baf640a6cbfd62d10f9689a5d9a
Gerrit-Change-Number: 23069
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>

[Impala-ASF-CR] IMPALA-14161: Thrift SSL tests fail on Centos 7

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23069 )

Change subject: IMPALA-14161: Thrift SSL tests fail on Centos 7
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12080/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/23069
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ade7e7308c05baf640a6cbfd62d10f9689a5d9a
Gerrit-Change-Number: 23069
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 25 Jun 2025 09:06:15 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14161: Thrift SSL tests fail on Centos 7

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23069 )

Change subject: IMPALA-14161: Thrift SSL tests fail on Centos 7
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/19561/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/23069
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ade7e7308c05baf640a6cbfd62d10f9689a5d9a
Gerrit-Change-Number: 23069
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Mon, 23 Jun 2025 14:33:50 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14161: Thrift SSL tests fail on Centos 7

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23069 )

Change subject: IMPALA-14161: Thrift SSL tests fail on Centos 7
......................................................................


Patch Set 2: Code-Review+1

> Patch Set 2:
> 
> It seems that we don't even need to add "AES256-GCM-SHA384", it is enough to set the cipher list in the test for the servers.
> My idea is that we can make the tests pass in two ways:
>  - Adding "AES256-GCM-SHA384" to the SecurityDefaults::SecurityDefaults::kDefaultTlsCiphers list in be/srckudu/security/security_flags.cc. This "fixes" the Thrift clients in the tests.
>  - Passing the default cipher list to the Thrift servers, which "fixes" the servers.
> I went with the second approach in this patch.

2nd approach make sense to me. But please double check that behavior/test scenario of some negative test about ciphers (BadCipher, MismatchCipher, MismatchedTlsCiphersuites) stays the same after applying this 2nd approach.


-- 
To view, visit http://gerrit.cloudera.org:8080/23069
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ade7e7308c05baf640a6cbfd62d10f9689a5d9a
Gerrit-Change-Number: 23069
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 24 Jun 2025 14:15:17 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14161: Thrift SSL tests fail on Centos 7

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/23069 )

Change subject: IMPALA-14161: Thrift SSL tests fail on Centos 7
......................................................................


Patch Set 2: Code-Review+2

This makes sense to me


-- 
To view, visit http://gerrit.cloudera.org:8080/23069
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ade7e7308c05baf640a6cbfd62d10f9689a5d9a
Gerrit-Change-Number: 23069
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 24 Jun 2025 19:15:03 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14161: Thrift SSL tests fail on Centos 7

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23069 )

Change subject: IMPALA-14161: Thrift SSL tests fail on Centos 7
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/23069
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ade7e7308c05baf640a6cbfd62d10f9689a5d9a
Gerrit-Change-Number: 23069
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 25 Jun 2025 15:11:13 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14161: Thrift SSL tests fail on Centos 7

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23069 )

Change subject: IMPALA-14161: Thrift SSL tests fail on Centos 7
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23069/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/23069/1//COMMIT_MSG@7
PS1, Line 7: IMPALA-14161: Thrift SSL tests fail on Centos 7
nit: Have you run thrift-server-test in Centos 7 with this patch?
If yes, please write Testing: section in commit message.



-- 
To view, visit http://gerrit.cloudera.org:8080/23069
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ade7e7308c05baf640a6cbfd62d10f9689a5d9a
Gerrit-Change-Number: 23069
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 23 Jun 2025 15:57:00 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14161: Thrift SSL tests fail on Centos 7

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23069 )

Change subject: IMPALA-14161: Thrift SSL tests fail on Centos 7
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/23069
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ade7e7308c05baf640a6cbfd62d10f9689a5d9a
Gerrit-Change-Number: 23069
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 25 Jun 2025 09:06:15 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14161: Thrift SSL tests fail on Centos 7

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23069 )

Change subject: IMPALA-14161: Thrift SSL tests fail on Centos 7
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/19582/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/23069
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ade7e7308c05baf640a6cbfd62d10f9689a5d9a
Gerrit-Change-Number: 23069
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 24 Jun 2025 14:29:58 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14161: Thrift SSL tests fail on Centos 7

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23069 )

Change subject: IMPALA-14161: Thrift SSL tests fail on Centos 7
......................................................................

IMPALA-14161: Thrift SSL tests fail on Centos 7

After the rebase of the Kudu code in to v1.17.1 (see IMPALA-14066), some
backend tests in thrift-server-test.cc stopped working on CentOs 7.9.

This is because the list of available TLS ciphers has been updated in
Kudu commit https://gerrit.cloudera.org/#/c/17268/, which was picked up
in the rebase.

This commit fixes the tests by making sure that the ThriftServers
started in the tests receive the list of ciphers.

Testing:
 - tested the patch on CentOS 7.9.

Change-Id: I2ade7e7308c05baf640a6cbfd62d10f9689a5d9a
Reviewed-on: http://gerrit.cloudera.org:8080/23069
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/rpc/thrift-server-test.cc
1 file changed, 28 insertions(+), 2 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/23069
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2ade7e7308c05baf640a6cbfd62d10f9689a5d9a
Gerrit-Change-Number: 23069
Gerrit-PatchSet: 4
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-14161: Thrift SSL tests fail on Centos 7

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/23069 )

Change subject: IMPALA-14161: Thrift SSL tests fail on Centos 7
......................................................................


Patch Set 1: Code-Review+1

Thanks, this looks good to me


-- 
To view, visit http://gerrit.cloudera.org:8080/23069
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ade7e7308c05baf640a6cbfd62d10f9689a5d9a
Gerrit-Change-Number: 23069
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 23 Jun 2025 23:12:49 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14161: Thrift SSL tests fail on Centos 7

Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/23069 )

Change subject: IMPALA-14161: Thrift SSL tests fail on Centos 7
......................................................................


Patch Set 2:

It seems that we don't even need to add "AES256-GCM-SHA384", it is enough to set the cipher list in the test for the servers.
My idea is that we can make the tests pass in two ways:
 - Adding "AES256-GCM-SHA384" to the SecurityDefaults::SecurityDefaults::kDefaultTlsCiphers list in be/srckudu/security/security_flags.cc. This "fixes" the Thrift clients in the tests.
 - Passing the default cipher list to the Thrift servers, which "fixes" the servers.
I went with the second approach in this patch.


-- 
To view, visit http://gerrit.cloudera.org:8080/23069
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ade7e7308c05baf640a6cbfd62d10f9689a5d9a
Gerrit-Change-Number: 23069
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 24 Jun 2025 14:06:12 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14161: Thrift SSL tests fail on Centos 7

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23069 )

Change subject: IMPALA-14161: Thrift SSL tests fail on Centos 7
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12082/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/23069
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ade7e7308c05baf640a6cbfd62d10f9689a5d9a
Gerrit-Change-Number: 23069
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 25 Jun 2025 09:43:02 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14161: Thrift SSL tests fail on Centos 7

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23069 )

Change subject: IMPALA-14161: Thrift SSL tests fail on Centos 7
......................................................................


Patch Set 1: Code-Review+2

Gave my +2 after Joe's +1.


-- 
To view, visit http://gerrit.cloudera.org:8080/23069
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ade7e7308c05baf640a6cbfd62d10f9689a5d9a
Gerrit-Change-Number: 23069
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 23 Jun 2025 23:43:54 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14161: Thrift SSL tests fail on Centos 7

Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/23069 )

Change subject: IMPALA-14161: Thrift SSL tests fail on Centos 7
......................................................................

IMPALA-14161: Thrift SSL tests fail on Centos 7

After the rebase of the Kudu code in to v1.17.1 (see IMPALA-14066), some
backend tests in thrift-server-test.cc stopped working on CentOs 7.9.

This is because the list of available TLS ciphers has been updated in
Kudu commit https://gerrit.cloudera.org/#/c/17268/, which was picked up
in the rebase.

This commit fixes the tests by making sure that the ThriftServers
started in the tests receive the list of ciphers.

Testing:
 - tested the patch on CentOS 7.9.

Change-Id: I2ade7e7308c05baf640a6cbfd62d10f9689a5d9a
---
M be/src/rpc/thrift-server-test.cc
1 file changed, 28 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/69/23069/2
-- 
To view, visit http://gerrit.cloudera.org:8080/23069
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2ade7e7308c05baf640a6cbfd62d10f9689a5d9a
Gerrit-Change-Number: 23069
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-14161: Thrift SSL tests fail on Centos 7

Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/23069 )

Change subject: IMPALA-14161: Thrift SSL tests fail on Centos 7
......................................................................


Patch Set 2:

Thanks. The negative tests seem ok to me, I've checked them.


-- 
To view, visit http://gerrit.cloudera.org:8080/23069
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ade7e7308c05baf640a6cbfd62d10f9689a5d9a
Gerrit-Change-Number: 23069
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 25 Jun 2025 09:43:18 +0000
Gerrit-HasComments: No