You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2022/11/07 05:17:52 UTC
[GitHub] [hive] Jinzhengxu opened a new pull request, #3735: HIVE-26710: Test `testThriftSetObjectInspector` is a flaky test
Jinzhengxu opened a new pull request, #3735:
URL: https://github.com/apache/hive/pull/3735
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Added two sort field codes to make the list order determined.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
This test is a flaky test. This is because the StructObjectInspector returns a not determinist list, which will cause the test sometimes pass and sometimes fail.
Run the test with 'NonDex' maven plugin. The command to recreate the flaky test failure is
`mvn -pl serde edu.illinois:nondex-maven-plugin:1.1.2:nondex -Dtest=org.apache.hadoop.hive.serde2.objectinspector.TestThriftObjectInspectors#testThriftSetObjectInspector`
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
All tests passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] commented on pull request #3735: HIVE-26710: Test `testThriftSetObjectInspector` is a flaky test
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #3735:
URL: https://github.com/apache/hive/pull/3735#issuecomment-1374298794
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Feel free to reach out on the dev@hive.apache.org list if the patch is in need of reviews.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] Jinzhengxu commented on pull request #3735: HIVE-26710: Test `testThriftSetObjectInspector` is a flaky test
Posted by GitBox <gi...@apache.org>.
Jinzhengxu commented on PR #3735:
URL: https://github.com/apache/hive/pull/3735#issuecomment-1383544057
Hi, Chris @cnauroth. Thank you for your response. I am not sure if the change in order of fields within StructField is caused by the use of HashSet or HashMap. There could be various reasons for this. However, Nondex does have a 'verbose' mode which is enabled by default. When you run Nondex, it will provide information about the mismatch in assertions for any failing test cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] cnauroth commented on a diff in pull request #3735: HIVE-26710: Test `testThriftSetObjectInspector` is a flaky test
Posted by GitBox <gi...@apache.org>.
cnauroth commented on code in PR #3735:
URL: https://github.com/apache/hive/pull/3735#discussion_r1064216233
##########
serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestThriftObjectInspectors.java:
##########
@@ -150,6 +152,11 @@ public void testThriftSetObjectInspector() throws Throwable {
assertEquals(Category.STRUCT, oi1.getCategory());
StructObjectInspector soi = (StructObjectInspector) oi1;
List<? extends StructField> fields = soi.getAllStructFieldRefs();
+ Collections.sort(fields, new Comparator<StructField>() {
Review Comment:
The `Comparator` anonymous inner class could be shortened to `Comparator.comparing(StructField::getFieldName)`.
##########
serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestThriftObjectInspectors.java:
##########
@@ -176,6 +183,11 @@ public void testThriftSetObjectInspector() throws Throwable {
assertEquals("setString", soi.getStructFieldData(s, fields.get(1)));
// sub fields
+ Collections.sort(fields, new Comparator<StructField>() {
Review Comment:
Similarly, this could be shortened to `Comparator.comparing(StructField::getFieldObjectInspector`.
However, I'm also not clear why it would need to be resorted by a different key for the next assertions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] closed pull request #3735: HIVE-26710: Test `testThriftSetObjectInspector` is a flaky test
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #3735: HIVE-26710: Test `testThriftSetObjectInspector` is a flaky test
URL: https://github.com/apache/hive/pull/3735
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] Jinzhengxu commented on a diff in pull request #3735: HIVE-26710: Test `testThriftSetObjectInspector` is a flaky test
Posted by GitBox <gi...@apache.org>.
Jinzhengxu commented on code in PR #3735:
URL: https://github.com/apache/hive/pull/3735#discussion_r1070861117
##########
serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestThriftObjectInspectors.java:
##########
@@ -150,6 +152,11 @@ public void testThriftSetObjectInspector() throws Throwable {
assertEquals(Category.STRUCT, oi1.getCategory());
StructObjectInspector soi = (StructObjectInspector) oi1;
List<? extends StructField> fields = soi.getAllStructFieldRefs();
+ Collections.sort(fields, new Comparator<StructField>() {
Review Comment:
Sure, this will make the code more concise and understandable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org