You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Nicolas Spiegelberg (Created) (JIRA)" <ji...@apache.org> on 2011/11/15 01:59:53 UTC

[jira] [Created] (HBASE-4785) Improve recovery time of HBase client when a region server dies.

Improve recovery time of HBase client when a region server dies.
----------------------------------------------------------------

                 Key: HBASE-4785
                 URL: https://issues.apache.org/jira/browse/HBASE-4785
             Project: HBase
          Issue Type: Improvement
            Reporter: Nicolas Spiegelberg
            Assignee: Nicolas Spiegelberg
            Priority: Minor
             Fix For: 0.94.0


When a region server dies, the HBase client waits until the RPC timesout before learning that it needs to check META to find the new location of the region. And it incurs this *timeout* cost for every region being served by the dead region server. Remove this overhead by clearing the entries in cache that have the dead region server as their values.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-4785) Improve recovery time of HBase client when a region server dies.

Posted by "Nicolas Spiegelberg (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nicolas Spiegelberg updated HBASE-4785:
---------------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)
    
> Improve recovery time of HBase client when a region server dies.
> ----------------------------------------------------------------
>
>                 Key: HBASE-4785
>                 URL: https://issues.apache.org/jira/browse/HBASE-4785
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Nicolas Spiegelberg
>            Assignee: Nicolas Spiegelberg
>            Priority: Minor
>             Fix For: 0.94.0
>
>         Attachments: HBASE-4785.patch, HBASE-4785.patch
>
>
> When a region server dies, the HBase client waits until the RPC timesout before learning that it needs to check META to find the new location of the region. And it incurs this *timeout* cost for every region being served by the dead region server. Remove this overhead by clearing the entries in cache that have the dead region server as their values.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-4785) Improve recovery time of HBase client when a region server dies.

Posted by "Ted Yu (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ted Yu updated HBASE-4785:
--------------------------

    Status: Open  (was: Patch Available)
    
> Improve recovery time of HBase client when a region server dies.
> ----------------------------------------------------------------
>
>                 Key: HBASE-4785
>                 URL: https://issues.apache.org/jira/browse/HBASE-4785
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Nicolas Spiegelberg
>            Assignee: Nicolas Spiegelberg
>            Priority: Minor
>             Fix For: 0.94.0
>
>         Attachments: HBASE-4785.patch, HBASE-4785.patch
>
>
> When a region server dies, the HBase client waits until the RPC timesout before learning that it needs to check META to find the new location of the region. And it incurs this *timeout* cost for every region being served by the dead region server. Remove this overhead by clearing the entries in cache that have the dead region server as their values.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4785) Improve recovery time of HBase client when a region server dies.

Posted by "Ted Yu (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13150182#comment-13150182 ] 

Ted Yu commented on HBASE-4785:
-------------------------------

The introduction of cachedServers is for fast lookup when clearing cached locations, right ?
                
> Improve recovery time of HBase client when a region server dies.
> ----------------------------------------------------------------
>
>                 Key: HBASE-4785
>                 URL: https://issues.apache.org/jira/browse/HBASE-4785
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Nicolas Spiegelberg
>            Assignee: Nicolas Spiegelberg
>            Priority: Minor
>             Fix For: 0.94.0
>
>         Attachments: HBASE-4785.patch
>
>
> When a region server dies, the HBase client waits until the RPC timesout before learning that it needs to check META to find the new location of the region. And it incurs this *timeout* cost for every region being served by the dead region server. Remove this overhead by clearing the entries in cache that have the dead region server as their values.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4785) Improve recovery time of HBase client when a region server dies.

Posted by "Nicolas Spiegelberg (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13156011#comment-13156011 ] 

Nicolas Spiegelberg commented on HBASE-4785:
--------------------------------------------

@stack : You're correct about the missing entrySet().  There was a previous commit in 89-fb (r1181942) that I could not find a use for.  I guess it's this feature.
                
> Improve recovery time of HBase client when a region server dies.
> ----------------------------------------------------------------
>
>                 Key: HBASE-4785
>                 URL: https://issues.apache.org/jira/browse/HBASE-4785
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Nicolas Spiegelberg
>            Assignee: Nicolas Spiegelberg
>            Priority: Minor
>             Fix For: 0.94.0
>
>         Attachments: HBASE-4785.patch
>
>
> When a region server dies, the HBase client waits until the RPC timesout before learning that it needs to check META to find the new location of the region. And it incurs this *timeout* cost for every region being served by the dead region server. Remove this overhead by clearing the entries in cache that have the dead region server as their values.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4785) Improve recovery time of HBase client when a region server dies.

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13156547#comment-13156547 ] 

Hudson commented on HBASE-4785:
-------------------------------

Integrated in HBase-0.92-security #11 (See [https://builds.apache.org/job/HBase-0.92-security/11/])
    HBASE-4785 Improve recovery time of HBase client when a region server dies

stack : 
Files : 
* /hbase/branches/0.92/CHANGES.txt
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/util/SoftValueSortedMap.java

                
> Improve recovery time of HBase client when a region server dies.
> ----------------------------------------------------------------
>
>                 Key: HBASE-4785
>                 URL: https://issues.apache.org/jira/browse/HBASE-4785
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Nicolas Spiegelberg
>            Assignee: Nicolas Spiegelberg
>            Priority: Minor
>             Fix For: 0.92.0
>
>         Attachments: HBASE-4785.patch, HBASE-4785.patch
>
>
> When a region server dies, the HBase client waits until the RPC timesout before learning that it needs to check META to find the new location of the region. And it incurs this *timeout* cost for every region being served by the dead region server. Remove this overhead by clearing the entries in cache that have the dead region server as their values.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4785) Improve recovery time of HBase client when a region server dies.

Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13150228#comment-13150228 ] 

Hadoop QA commented on HBASE-4785:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12503700/HBASE-4785.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 javadoc.  The javadoc tool appears to have generated -163 warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 51 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

     -1 core tests.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.TestZooKeeper
                  org.apache.hadoop.hbase.master.TestRollingRestart
                  org.apache.hadoop.hbase.TestFullLogReconstruction
                  org.apache.hadoop.hbase.catalog.TestMetaReaderEditor
                  org.apache.hadoop.hbase.client.TestScannerTimeout
                  org.apache.hadoop.hbase.master.TestMasterFailover

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/251//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/251//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/251//console

This message is automatically generated.
                
> Improve recovery time of HBase client when a region server dies.
> ----------------------------------------------------------------
>
>                 Key: HBASE-4785
>                 URL: https://issues.apache.org/jira/browse/HBASE-4785
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Nicolas Spiegelberg
>            Assignee: Nicolas Spiegelberg
>            Priority: Minor
>             Fix For: 0.94.0
>
>         Attachments: HBASE-4785.patch
>
>
> When a region server dies, the HBase client waits until the RPC timesout before learning that it needs to check META to find the new location of the region. And it incurs this *timeout* cost for every region being served by the dead region server. Remove this overhead by clearing the entries in cache that have the dead region server as their values.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-4785) Improve recovery time of HBase client when a region server dies.

Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HBASE-4785:
-------------------------

    Fix Version/s:     (was: 0.94.0)
                   0.92.0

I put this on 0.92 too.
                
> Improve recovery time of HBase client when a region server dies.
> ----------------------------------------------------------------
>
>                 Key: HBASE-4785
>                 URL: https://issues.apache.org/jira/browse/HBASE-4785
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Nicolas Spiegelberg
>            Assignee: Nicolas Spiegelberg
>            Priority: Minor
>             Fix For: 0.92.0
>
>         Attachments: HBASE-4785.patch, HBASE-4785.patch
>
>
> When a region server dies, the HBase client waits until the RPC timesout before learning that it needs to check META to find the new location of the region. And it incurs this *timeout* cost for every region being served by the dead region server. Remove this overhead by clearing the entries in cache that have the dead region server as their values.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-4785) Improve recovery time of HBase client when a region server dies.

Posted by "Nicolas Spiegelberg (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nicolas Spiegelberg updated HBASE-4785:
---------------------------------------

    Attachment: HBASE-4785.patch
    
> Improve recovery time of HBase client when a region server dies.
> ----------------------------------------------------------------
>
>                 Key: HBASE-4785
>                 URL: https://issues.apache.org/jira/browse/HBASE-4785
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Nicolas Spiegelberg
>            Assignee: Nicolas Spiegelberg
>            Priority: Minor
>             Fix For: 0.94.0
>
>         Attachments: HBASE-4785.patch
>
>
> When a region server dies, the HBase client waits until the RPC timesout before learning that it needs to check META to find the new location of the region. And it incurs this *timeout* cost for every region being served by the dead region server. Remove this overhead by clearing the entries in cache that have the dead region server as their values.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4785) Improve recovery time of HBase client when a region server dies.

Posted by "Nicolas Spiegelberg (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13150133#comment-13150133 ] 

Nicolas Spiegelberg commented on HBASE-4785:
--------------------------------------------

Part of 89-fb to trunk port.  See r1181949.
                
> Improve recovery time of HBase client when a region server dies.
> ----------------------------------------------------------------
>
>                 Key: HBASE-4785
>                 URL: https://issues.apache.org/jira/browse/HBASE-4785
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Nicolas Spiegelberg
>            Assignee: Nicolas Spiegelberg
>            Priority: Minor
>             Fix For: 0.94.0
>
>
> When a region server dies, the HBase client waits until the RPC timesout before learning that it needs to check META to find the new location of the region. And it incurs this *timeout* cost for every region being served by the dead region server. Remove this overhead by clearing the entries in cache that have the dead region server as their values.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-4785) Improve recovery time of HBase client when a region server dies.

Posted by "Nicolas Spiegelberg (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nicolas Spiegelberg updated HBASE-4785:
---------------------------------------

    Status: Patch Available  (was: Open)
    
> Improve recovery time of HBase client when a region server dies.
> ----------------------------------------------------------------
>
>                 Key: HBASE-4785
>                 URL: https://issues.apache.org/jira/browse/HBASE-4785
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Nicolas Spiegelberg
>            Assignee: Nicolas Spiegelberg
>            Priority: Minor
>             Fix For: 0.94.0
>
>         Attachments: HBASE-4785.patch
>
>
> When a region server dies, the HBase client waits until the RPC timesout before learning that it needs to check META to find the new location of the region. And it incurs this *timeout* cost for every region being served by the dead region server. Remove this overhead by clearing the entries in cache that have the dead region server as their values.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4785) Improve recovery time of HBase client when a region server dies.

Posted by "Ted Yu (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13156207#comment-13156207 ] 

Ted Yu commented on HBASE-4785:
-------------------------------

+1 on patch v2.
                
> Improve recovery time of HBase client when a region server dies.
> ----------------------------------------------------------------
>
>                 Key: HBASE-4785
>                 URL: https://issues.apache.org/jira/browse/HBASE-4785
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Nicolas Spiegelberg
>            Assignee: Nicolas Spiegelberg
>            Priority: Minor
>             Fix For: 0.94.0
>
>         Attachments: HBASE-4785.patch, HBASE-4785.patch
>
>
> When a region server dies, the HBase client waits until the RPC timesout before learning that it needs to check META to find the new location of the region. And it incurs this *timeout* cost for every region being served by the dead region server. Remove this overhead by clearing the entries in cache that have the dead region server as their values.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4785) Improve recovery time of HBase client when a region server dies.

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13159779#comment-13159779 ] 

Hudson commented on HBASE-4785:
-------------------------------

Integrated in HBase-0.92 #163 (See [https://builds.apache.org/job/HBase-0.92/163/])
    HBASE-4785 Improve recovery time of HBase client when a region server dies

stack : 
Files : 
* /hbase/branches/0.92/CHANGES.txt
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/util/SoftValueSortedMap.java

                
> Improve recovery time of HBase client when a region server dies.
> ----------------------------------------------------------------
>
>                 Key: HBASE-4785
>                 URL: https://issues.apache.org/jira/browse/HBASE-4785
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Nicolas Spiegelberg
>            Assignee: Nicolas Spiegelberg
>            Priority: Minor
>             Fix For: 0.92.0
>
>         Attachments: HBASE-4785.patch, HBASE-4785.patch
>
>
> When a region server dies, the HBase client waits until the RPC timesout before learning that it needs to check META to find the new location of the region. And it incurs this *timeout* cost for every region being served by the dead region server. Remove this overhead by clearing the entries in cache that have the dead region server as their values.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4785) Improve recovery time of HBase client when a region server dies.

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13156629#comment-13156629 ] 

Hudson commented on HBASE-4785:
-------------------------------

Integrated in HBase-TRUNK-security #7 (See [https://builds.apache.org/job/HBase-TRUNK-security/7/])
    HBASE-4785 Improve recovery time of HBase client when a region server dies.

nspiegelberg : 
Files : 
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/SoftValueSortedMap.java

                
> Improve recovery time of HBase client when a region server dies.
> ----------------------------------------------------------------
>
>                 Key: HBASE-4785
>                 URL: https://issues.apache.org/jira/browse/HBASE-4785
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Nicolas Spiegelberg
>            Assignee: Nicolas Spiegelberg
>            Priority: Minor
>             Fix For: 0.92.0
>
>         Attachments: HBASE-4785.patch, HBASE-4785.patch
>
>
> When a region server dies, the HBase client waits until the RPC timesout before learning that it needs to check META to find the new location of the region. And it incurs this *timeout* cost for every region being served by the dead region server. Remove this overhead by clearing the entries in cache that have the dead region server as their values.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4785) Improve recovery time of HBase client when a region server dies.

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13156504#comment-13156504 ] 

Hudson commented on HBASE-4785:
-------------------------------

Integrated in HBase-TRUNK #2476 (See [https://builds.apache.org/job/HBase-TRUNK/2476/])
    HBASE-4785 Improve recovery time of HBase client when a region server dies.

nspiegelberg : 
Files : 
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/SoftValueSortedMap.java

                
> Improve recovery time of HBase client when a region server dies.
> ----------------------------------------------------------------
>
>                 Key: HBASE-4785
>                 URL: https://issues.apache.org/jira/browse/HBASE-4785
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Nicolas Spiegelberg
>            Assignee: Nicolas Spiegelberg
>            Priority: Minor
>             Fix For: 0.92.0
>
>         Attachments: HBASE-4785.patch, HBASE-4785.patch
>
>
> When a region server dies, the HBase client waits until the RPC timesout before learning that it needs to check META to find the new location of the region. And it incurs this *timeout* cost for every region being served by the dead region server. Remove this overhead by clearing the entries in cache that have the dead region server as their values.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-4785) Improve recovery time of HBase client when a region server dies.

Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HBASE-4785:
-------------------------


I put this on 0.92 too.
                
> Improve recovery time of HBase client when a region server dies.
> ----------------------------------------------------------------
>
>                 Key: HBASE-4785
>                 URL: https://issues.apache.org/jira/browse/HBASE-4785
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Nicolas Spiegelberg
>            Assignee: Nicolas Spiegelberg
>            Priority: Minor
>             Fix For: 0.92.0
>
>         Attachments: HBASE-4785.patch, HBASE-4785.patch
>
>
> When a region server dies, the HBase client waits until the RPC timesout before learning that it needs to check META to find the new location of the region. And it incurs this *timeout* cost for every region being served by the dead region server. Remove this overhead by clearing the entries in cache that have the dead region server as their values.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4785) Improve recovery time of HBase client when a region server dies.

Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13156269#comment-13156269 ] 

Hadoop QA commented on HBASE-4785:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12504907/HBASE-4785.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 javadoc.  The javadoc tool appears to have generated -162 warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 66 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

     -1 core tests.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.client.TestAdmin
                  org.apache.hadoop.hbase.regionserver.wal.TestLogRolling

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/349//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/349//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/349//console

This message is automatically generated.
                
> Improve recovery time of HBase client when a region server dies.
> ----------------------------------------------------------------
>
>                 Key: HBASE-4785
>                 URL: https://issues.apache.org/jira/browse/HBASE-4785
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Nicolas Spiegelberg
>            Assignee: Nicolas Spiegelberg
>            Priority: Minor
>             Fix For: 0.94.0
>
>         Attachments: HBASE-4785.patch, HBASE-4785.patch
>
>
> When a region server dies, the HBase client waits until the RPC timesout before learning that it needs to check META to find the new location of the region. And it incurs this *timeout* cost for every region being served by the dead region server. Remove this overhead by clearing the entries in cache that have the dead region server as their values.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-4785) Improve recovery time of HBase client when a region server dies.

Posted by "Nicolas Spiegelberg (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nicolas Spiegelberg updated HBASE-4785:
---------------------------------------

    Attachment: HBASE-4785.patch

Fixes SoftValueSortedMap.  Internal comments:

Currently SoftValueSortedMap.entrySet() tries to iteraate through the entry set of the underlying map, and put all the values (SoftValue<K,V>) to a newly created TreeSet<Entry<K,V>>. The entry set of SortedMap is already sorted, so it's not necessary to have a TreeSet to sort those entries again upon adding. This gets rid of the runtime class cast exception because it does not require comparing anymore.
                
> Improve recovery time of HBase client when a region server dies.
> ----------------------------------------------------------------
>
>                 Key: HBASE-4785
>                 URL: https://issues.apache.org/jira/browse/HBASE-4785
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Nicolas Spiegelberg
>            Assignee: Nicolas Spiegelberg
>            Priority: Minor
>             Fix For: 0.94.0
>
>         Attachments: HBASE-4785.patch, HBASE-4785.patch
>
>
> When a region server dies, the HBase client waits until the RPC timesout before learning that it needs to check META to find the new location of the region. And it incurs this *timeout* cost for every region being served by the dead region server. Remove this overhead by clearing the entries in cache that have the dead region server as their values.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4785) Improve recovery time of HBase client when a region server dies.

Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13150236#comment-13150236 ] 

stack commented on HBASE-4785:
------------------------------

clearCachedLocationForServer javadoc has two params but method only takes one.  Can fix on commit.

This could just be a Map?

{code}
for (SoftValueSortedMap<byte[], HRegionLocation> tableLocations
{code}

...rather thana SoftValueSortedMap... or a NavigableMap or SortedMap?  No biggie.

+1 on patch and for 0.92.  Why the failures above though?   A bunch of stuff failed.  Oh.... funny:

{code}
java.lang.RuntimeException: Not implemented
	at org.apache.hadoop.hbase.util.SoftValueSortedMap.entrySet(SoftValueSortedMap.java:175)
{code}

Looks like your patch is missing a piece Nicolas.
                
> Improve recovery time of HBase client when a region server dies.
> ----------------------------------------------------------------
>
>                 Key: HBASE-4785
>                 URL: https://issues.apache.org/jira/browse/HBASE-4785
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Nicolas Spiegelberg
>            Assignee: Nicolas Spiegelberg
>            Priority: Minor
>             Fix For: 0.94.0
>
>         Attachments: HBASE-4785.patch
>
>
> When a region server dies, the HBase client waits until the RPC timesout before learning that it needs to check META to find the new location of the region. And it incurs this *timeout* cost for every region being served by the dead region server. Remove this overhead by clearing the entries in cache that have the dead region server as their values.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-4785) Improve recovery time of HBase client when a region server dies.

Posted by "Ted Yu (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ted Yu updated HBASE-4785:
--------------------------

    Status: Patch Available  (was: Open)
    
> Improve recovery time of HBase client when a region server dies.
> ----------------------------------------------------------------
>
>                 Key: HBASE-4785
>                 URL: https://issues.apache.org/jira/browse/HBASE-4785
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Nicolas Spiegelberg
>            Assignee: Nicolas Spiegelberg
>            Priority: Minor
>             Fix For: 0.94.0
>
>         Attachments: HBASE-4785.patch, HBASE-4785.patch
>
>
> When a region server dies, the HBase client waits until the RPC timesout before learning that it needs to check META to find the new location of the region. And it incurs this *timeout* cost for every region being served by the dead region server. Remove this overhead by clearing the entries in cache that have the dead region server as their values.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira