[GitHub] [spark] cloud-fan commented on a diff in pull request #40576: [SPARK-42946][SQL] Redact sensitive data which is nested by variable substitution

["cloud-fan (via GitHub)" <gi...@apache.org>]

cloud-fan commented on code in PR #40576:
URL: https://github.com/apache/spark/pull/40576#discussion_r1150646819


##########
sql/core/src/test/scala/org/apache/spark/sql/SetCommandSuite.scala:
##########
@@ -143,4 +144,15 @@ class SetCommandSuite extends QueryTest with SharedSparkSession with ResetSystem
       assert(!allValues.exists(v => v.contains(value1) || v.contains(value2)))
     }
   }
+
+  test("SPARK-42946: Set command could expose sensitive data through key") {
+    val key1 = "test.password"
+    val value1 = "test.value1"
+    withSQLConf(key1 -> value1) {
+      checkError(
+        intercept[ParseException](sql("SET ${test.password}")),

Review Comment:
   It did not fail before this PR?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org