You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/04/09 15:38:52 UTC
[GitHub] [flink-kubernetes-operator] SteNicholas opened a new pull request, #163: [FLINK-27154] Disable web.cancel.enable for application clusters
SteNicholas opened a new pull request, #163:
URL: https://github.com/apache/flink-kubernetes-operator/pull/163
`web.cancel.enable` should be set to false for application deployments to avoid users accidentally cancelling jobs.
**The brief change log**
- `FlinkConfigBuilder` set `web.cancel.enable` to false for application deployments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] gyfora merged pull request #163: [FLINK-27154] Disable web.cancel.enable for application clusters
Posted by GitBox <gi...@apache.org>.
gyfora merged PR #163:
URL: https://github.com/apache/flink-kubernetes-operator/pull/163
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #163: [FLINK-27154] Disable web.cancel.enable for application clusters
Posted by GitBox <gi...@apache.org>.
gyfora commented on code in PR #163:
URL: https://github.com/apache/flink-kubernetes-operator/pull/163#discussion_r846826436
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/utils/FlinkConfigBuilder.java:
##########
@@ -100,16 +101,22 @@ public FlinkConfigBuilder applyFlinkConfiguration() {
KubernetesConfigOptions.ServiceExposedType.ClusterIP);
}
- // With last-state upgrade mode, set the default value of 'execution.checkpointing.interval'
- // to 5 minutes when HA is enabled.
- if (spec.getJob() != null
- && spec.getJob().getUpgradeMode() == UpgradeMode.LAST_STATE
- && !effectiveConfig.contains(
- ExecutionCheckpointingOptions.CHECKPOINTING_INTERVAL)) {
- effectiveConfig.set(
- ExecutionCheckpointingOptions.CHECKPOINTING_INTERVAL,
- DEFAULT_CHECKPOINTING_INTERVAL);
+ if (spec.getJob() != null) {
+ // Set 'web.cancel.enable' to false for application deployments to avoid users
+ // accidentally cancelling jobs.
+ effectiveConfig.set(CANCEL_ENABLE, false);
Review Comment:
We should not set this if the user explicitly set it to true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org