You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/10/07 15:33:49 UTC

[GitHub] [camel] orpiske commented on a diff in pull request #8391: [Camel 18327] updated updateTaskState resume logic to seek from the point that was last committed

orpiske commented on code in PR #8391:
URL: https://github.com/apache/camel/pull/8391#discussion_r990216850


##########
components/camel-kafka/src/main/java/org/apache/camel/component/kafka/KafkaFetchRecords.java:
##########
@@ -507,7 +517,7 @@ private boolean isReady() {
         } catch (Exception e) {
             // ignore
             LOG.debug("Cannot check hasReadyNodes on KafkaConsumer client (ConsumerNetworkClient) due to: "
-                      + e.getMessage() + ". This exception is ignored.",
+                            + e.getMessage() + ". This exception is ignored.",

Review Comment:
   The format check may be complaining because of this line. If you look at it, you can see that it's different than the previous version.



##########
components/camel-kafka/src/main/java/org/apache/camel/component/kafka/KafkaFetchRecords.java:
##########
@@ -176,7 +178,7 @@ private void setupCreateConsumerException(ForegroundTask task, int max) {
         String time = TimeUtils.printDuration(task.elapsed(), true);
         String topic = getPrintableTopic();
         String msg = "Gave up creating org.apache.kafka.clients.consumer.KafkaConsumer "
-                     + threadId + " to " + topic + " after " + max + " attempts (elapsed: " + time + ").";
+                + threadId + " to " + topic + " after " + max + " attempts (elapsed: " + time + ").";

Review Comment:
   The format check may be complaining because of this line. If you look at it, you can see that it's different than the previous version.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org