You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "cstamas (via GitHub)" <gi...@apache.org> on 2023/03/01 09:44:46 UTC
[GitHub] [maven] cstamas opened a new pull request, #1020: [MNG-7713] Drop legacy-local-repository option
cstamas opened a new pull request, #1020:
URL: https://github.com/apache/maven/pull/1020
There is really no need for it, and there is a resolver option if really must (but really should not, local repo is and should be considered as transient).
---
https://issues.apache.org/jira/browse/MNG-7713
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] cstamas commented on a diff in pull request #1020: [MNG-7713] Drop legacy-local-repository option
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on code in PR #1020:
URL: https://github.com/apache/maven/pull/1020#discussion_r1121464442
##########
maven-core/src/main/java/org/apache/maven/execution/MavenExecutionRequest.java:
##########
@@ -443,12 +443,20 @@ public interface MavenExecutionRequest {
/**
* @since 3.1
+ * @deprecated Since 3.9 there is no direct Maven2 interop offered at LRM level. See
+ * <a href="https://maven.apache.org/resolver/configuration.html">Resolver Configuration</a> page option
+ * {@code aether.artifactResolver.simpleLrmInterop} that provides similar semantics.
*/
+ @Deprecated
boolean isUseLegacyLocalRepository();
/**
* @since 3.1
+ * @deprecated Since 3.9 there is no direct Maven2 interop offered at LRM level. See
+ * <a href="https://maven.apache.org/resolver/configuration.html">Resolver Configuration</a> page option
+ * {@code aether.artifactResolver.simpleLrmInterop} that provides similar semantics.
*/
+ @Deprecated
MavenExecutionRequest setUseLegacyLocalRepository(boolean useLegacyLocalRepository);
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] cstamas merged pull request #1020: [MNG-7713] Drop legacy-local-repository option
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas merged PR #1020:
URL: https://github.com/apache/maven/pull/1020
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on a diff in pull request #1020: [MNG-7713] Drop legacy-local-repository option
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on code in PR #1020:
URL: https://github.com/apache/maven/pull/1020#discussion_r1121456848
##########
maven-core/src/main/java/org/apache/maven/execution/MavenExecutionRequest.java:
##########
@@ -443,12 +443,20 @@ public interface MavenExecutionRequest {
/**
* @since 3.1
+ * @deprecated Since 3.9 there is no direct Maven2 interop offered at LRM level. See
+ * <a href="https://maven.apache.org/resolver/configuration.html">Resolver Configuration</a> page option
+ * {@code aether.artifactResolver.simpleLrmInterop} that provides similar semantics.
*/
+ @Deprecated
boolean isUseLegacyLocalRepository();
/**
* @since 3.1
+ * @deprecated Since 3.9 there is no direct Maven2 interop offered at LRM level. See
+ * <a href="https://maven.apache.org/resolver/configuration.html">Resolver Configuration</a> page option
+ * {@code aether.artifactResolver.simpleLrmInterop} that provides similar semantics.
*/
+ @Deprecated
MavenExecutionRequest setUseLegacyLocalRepository(boolean useLegacyLocalRepository);
Review Comment:
Those commens should say that those are noop or *always* `false`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on a diff in pull request #1020: [MNG-7713] Drop legacy-local-repository option
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on code in PR #1020:
URL: https://github.com/apache/maven/pull/1020#discussion_r1121469512
##########
maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java:
##########
@@ -843,13 +842,6 @@ private void encryption(CliRequest cliRequest) throws Exception {
}
}
- private void repository(CliRequest cliRequest) throws Exception {
- if (cliRequest.commandLine.hasOption(CLIManager.LEGACY_LOCAL_REPOSITORY)
- || Boolean.getBoolean("maven.legacyLocalRepo")) {
Review Comment:
Interesting, it has been wrong. It should have been user prop, then sys prop...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org