You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "Konstantine Karantasis (Jira)" <ji...@apache.org> on 2020/03/10 03:02:00 UTC
[jira] [Comment Edited] (KAFKA-9682) Flaky Test
KafkaBasedLogTest#testSendAndReadToEnd
[ https://issues.apache.org/jira/browse/KAFKA-9682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17055540#comment-17055540 ]
Konstantine Karantasis edited comment on KAFKA-9682 at 3/10/20, 3:01 AM:
-------------------------------------------------------------------------
This test case broke with the consolidation of {{addEndOffsets}} and {{updateEndOffsets}} into a single {{updateEndOffsets}} in: [https://github.com/apache/kafka/pull/8220]
Before this PR, {{addEndOffsets}} was unused.
However, instead of consolidating {{innerUpdateEndOffsets}} that was called by both methods to become what the public {{updateEndOffsets}} was doing, it was refactored in a way that was actually executed what the unused {{addEndOffsets}} was performing.
Refactoring should have resulted into decommissioning {{addEndOffsets}} and keeping the original {{updateEndOffsets}}, not the other way round.
was (Author: kkonstantine):
This test case broke with the consolidation of `addEndOffsets` and `updateEndOffsets` into a single `updateEndOffsets` in: [https://github.com/apache/kafka/pull/8220]
Before this PR, `addEndOffsets` was unused.
However, instead of consolidating `innerUpdateEndOffsets` that was called by both methods to become what the public `updateEndOffsets` was doing, it was refactored in a way that was actually executed what the unused `addEndOffsets` was performing.
Refactoring should have resulted into decommissioning `addEndOffsets` and keeping the original `updateEndOffsets`, not the other way round.
> Flaky Test KafkaBasedLogTest#testSendAndReadToEnd
> -------------------------------------------------
>
> Key: KAFKA-9682
> URL: https://issues.apache.org/jira/browse/KAFKA-9682
> Project: Kafka
> Issue Type: Bug
> Components: KafkaConnect, unit tests
> Reporter: Matthias J. Sax
> Priority: Critical
>
> [https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/1048/testReport/org.apache.kafka.connect.util/KafkaBasedLogTest/testSendAndReadToEnd/]
> {quote}java.lang.AssertionError: expected:<2> but was:<0> at org.junit.Assert.fail(Assert.java:89) at org.junit.Assert.failNotEquals(Assert.java:835) at org.junit.Assert.assertEquals(Assert.java:647) at org.junit.Assert.assertEquals(Assert.java:633) at org.apache.kafka.connect.util.KafkaBasedLogTest.testSendAndReadToEnd(KafkaBasedLogTest.java:355){quote}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)