You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "michaeljmarshall (via GitHub)" <gi...@apache.org> on 2023/05/10 05:35:36 UTC
[GitHub] [pulsar] michaeljmarshall opened a new pull request, #20289: [cleanup] Deduplicate test certificates to simplify management
michaeljmarshall opened a new pull request, #20289:
URL: https://github.com/apache/pulsar/pull/20289
### Motivation
While working on my draft to enable hostname verification by default (https://github.com/apache/pulsar/pull/20268), I ran into some issues with certificates and noticed that we have several that are unnecessarily duplicated. This PR removes those duplicates and configures the affected tests to retrieve the certificates from the correct location.
### Modifications
* Remove duplicated certificates from several tests
* Update configurations to get the certificates from the correct location
* In `AuthedAdminProxyHandlerTest`, configure proxy to use proxy certs instead of broker certs. This is mostly a cosmetic change because they share the same root CA and they are on the same host, but it seems more correct.
### Verifying this change
I verified this by checking that the certs were the same. When tests pass, we can have a high confidence that this change is complete.
### Documentation
- [x] `doc-not-needed`
### Matching PR in forked repository
PR in forked repository: I ran all affected tests locally and got them to pass, so skipping the forked tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codecov-commenter commented on pull request #20289: [cleanup] Deduplicate test certificates to simplify management
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #20289:
URL: https://github.com/apache/pulsar/pull/20289#issuecomment-1542318420
## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/20289?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#20289](https://app.codecov.io/gh/apache/pulsar/pull/20289?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (78d5f50) into [master](https://app.codecov.io/gh/apache/pulsar/commit/bc1764f9ef71dd31e8cd61c7571e493442bc6395?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bc1764f) will **increase** coverage by `38.42%`.
> The diff coverage is `66.66%`.
[](https://app.codecov.io/gh/apache/pulsar/pull/20289?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #20289 +/- ##
=============================================
+ Coverage 34.48% 72.90% +38.42%
- Complexity 12528 31953 +19425
=============================================
Files 1614 1868 +254
Lines 126177 138588 +12411
Branches 13772 15237 +1465
=============================================
+ Hits 43508 101037 +57529
+ Misses 77051 29509 -47542
- Partials 5618 8042 +2424
```
| Flag | Coverage Δ | |
|---|---|---|
| inttests | `24.18% <38.88%> (+0.05%)` | :arrow_up: |
| systests | `24.75% <11.11%> (?)` | |
| unittests | `72.20% <66.66%> (+39.10%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/pulsar/pull/20289?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...r/broker/authentication/AuthenticationService.java](https://app.codecov.io/gh/apache/pulsar/pull/20289?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3B1bHNhci9icm9rZXIvYXV0aGVudGljYXRpb24vQXV0aGVudGljYXRpb25TZXJ2aWNlLmphdmE=) | `69.52% <37.50%> (+35.52%)` | :arrow_up: |
| [...oker/service/nonpersistent/NonPersistentTopic.java](https://app.codecov.io/gh/apache/pulsar/pull/20289?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL25vbnBlcnNpc3RlbnQvTm9uUGVyc2lzdGVudFRvcGljLmphdmE=) | `74.29% <66.66%> (+23.86%)` | :arrow_up: |
| [...rvice/nonpersistent/NonPersistentSubscription.java](https://app.codecov.io/gh/apache/pulsar/pull/20289?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL25vbnBlcnNpc3RlbnQvTm9uUGVyc2lzdGVudFN1YnNjcmlwdGlvbi5qYXZh) | `53.29% <100.00%> (+16.04%)` | :arrow_up: |
| [...va/org/apache/pulsar/client/impl/ConsumerImpl.java](https://app.codecov.io/gh/apache/pulsar/pull/20289?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NsaWVudC9pbXBsL0NvbnN1bWVySW1wbC5qYXZh) | `76.14% <100.00%> (+15.95%)` | :arrow_up: |
| [...he/pulsar/client/impl/MultiTopicsConsumerImpl.java](https://app.codecov.io/gh/apache/pulsar/pull/20289?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NsaWVudC9pbXBsL011bHRpVG9waWNzQ29uc3VtZXJJbXBsLmphdmE=) | `78.26% <100.00%> (+30.98%)` | :arrow_up: |
... and [1503 files with indirect coverage changes](https://app.codecov.io/gh/apache/pulsar/pull/20289/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari merged pull request #20289: [cleanup] Deduplicate test certificates to simplify management
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari merged PR #20289:
URL: https://github.com/apache/pulsar/pull/20289
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org