[GitHub] spark pull request: [SPARK-14124] [SQL] [FOLLOWUP] Implement Datab...

[gatorsmile <gi...@git.apache.org>]

Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12081#discussion_r58169289
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala ---
    @@ -116,8 +116,9 @@ class SessionCatalog(
         currentDb = db
       }
     
    -  def getDefaultDBPath(db: String): String = {
    -    System.getProperty("java.io.tmpdir") + File.separator + db + ".db"
    +  def getDatabasePath(dbName: String, path: Option[String]): String = {
    --- End diff --
    
    Actually, I am also wondering if we should return an empty String in non-Hive tables? Let me know if we need to remove it. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org