You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by dw...@apache.org on 2024/10/09 09:49:04 UTC
(lucene) branch branch_10x updated: Adds changes entry and migration comments #13820.
This is an automated email from the ASF dual-hosted git repository.
dweiss pushed a commit to branch branch_10x
in repository https://gitbox.apache.org/repos/asf/lucene.git
The following commit(s) were added to refs/heads/branch_10x by this push:
new ac91b32a266 Adds changes entry and migration comments #13820.
ac91b32a266 is described below
commit ac91b32a26686b401de0a17932412d6b206916af
Author: Dawid Weiss <da...@carrotsearch.com>
AuthorDate: Wed Oct 9 11:48:26 2024 +0200
Adds changes entry and migration comments #13820.
---
lucene/CHANGES.txt | 3 +++
lucene/MIGRATE.md | 6 ++++++
2 files changed, 9 insertions(+)
diff --git a/lucene/CHANGES.txt b/lucene/CHANGES.txt
index 23fec59dec7..023c1733b31 100644
--- a/lucene/CHANGES.txt
+++ b/lucene/CHANGES.txt
@@ -160,6 +160,9 @@ API Changes
* GITHUB#13845: Add missing with-discountOverlaps Similarity constructor variants. (Pierre Salagnac, Christine Poerschke, Robert Muir)
+* GITHUB#13820, GITHUB#13825, GITHUB#13830: Corrects DataInput.readGroupVInts to be public and not-final, removes the protected
+ DataInput.readGroupVInt method. (Zhang Chao, Robert Muir, Uwe Schindler, Dawid Weiss)
+
New Features
---------------------
diff --git a/lucene/MIGRATE.md b/lucene/MIGRATE.md
index 3052c7319ac..bf9e220390c 100644
--- a/lucene/MIGRATE.md
+++ b/lucene/MIGRATE.md
@@ -19,6 +19,12 @@
## Migration from Lucene 9.x to Lucene 10.0
+### Changes to DataInput.readGroupVInt and readGroupVInts methods
+
+As part of GITHUB#13820, GITHUB#13825, GITHUB#13830, this issue corrects DataInput.readGroupVInts
+to be public and not-final, allowing subclasses to override it. This change also removes the protected
+DataInput.readGroupVInt method: subclasses should delegate or reimplement it entirely.
+
### OpenNLP dependency upgrade
[Apache OpenNLP](https://opennlp.apache.org) 2.x opens the door to accessing various models via the ONNX runtime. To migrate you will need to update any deprecated OpenNLP methods that you may be using.