You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jan Schlicht <ja...@mesosphere.io> on 2017/09/01 10:23:27 UTC
Re: Review Request 61946: Added validation of resource provider
operations.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61946/
-----------------------------------------------------------
(Updated Sept. 1, 2017, 12:23 p.m.)
Review request for mesos, Benjamin Bannier and Jie Yu.
Bugs: MESOS-7594
https://issues.apache.org/jira/browse/MESOS-7594
Repository: mesos
Description
-------
Added validation of resource provider operations.
Diffs
-----
src/master/validation.hpp f4925752f20ae8ca4de1d9b4a3d5ffc394db9585
src/master/validation.cpp 7c3247d407c9e6aa8cce457d6c6be0c39f4b532f
Diff: https://reviews.apache.org/r/61946/diff/1/
Testing
-------
make check
Thanks,
Jan Schlicht
Re: Review Request 61946: Added validation of resource provider
operations.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61946/#review189007
-----------------------------------------------------------
src/master/validation.cpp
Lines 2266-2268 (patched)
<https://reviews.apache.org/r/61946/#comment265935>
This check is not necessary. Even if it passes the validation here, it might fail the following 'contains' check because some other operation in the same accept call used the resources. I'll simply remove this check here.
- Jie Yu
On Oct. 18, 2017, 1:51 p.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61946/
> -----------------------------------------------------------
>
> (Updated Oct. 18, 2017, 1:51 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Jie Yu.
>
>
> Bugs: MESOS-7594
> https://issues.apache.org/jira/browse/MESOS-7594
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added validation of resource provider operations.
>
>
> Diffs
> -----
>
> src/master/validation.hpp f4925752f20ae8ca4de1d9b4a3d5ffc394db9585
> src/master/validation.cpp 01bc2e0ad4de0bad570453cdaafb260c61c511eb
>
>
> Diff: https://reviews.apache.org/r/61946/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 61946: Added validation of resource provider
operations.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61946/
-----------------------------------------------------------
(Updated Oct. 18, 2017, 3:51 p.m.)
Review request for mesos, Benjamin Bannier and Jie Yu.
Changes
-------
Renamed variables.
Bugs: MESOS-7594
https://issues.apache.org/jira/browse/MESOS-7594
Repository: mesos
Description
-------
Added validation of resource provider operations.
Diffs (updated)
-----
src/master/validation.hpp f4925752f20ae8ca4de1d9b4a3d5ffc394db9585
src/master/validation.cpp 01bc2e0ad4de0bad570453cdaafb260c61c511eb
Diff: https://reviews.apache.org/r/61946/diff/2/
Changes: https://reviews.apache.org/r/61946/diff/1-2/
Testing
-------
make check
Thanks,
Jan Schlicht