You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "chickenlj (GitHub)" <gi...@apache.org> on 2019/04/10 10:45:50 UTC
[GitHub] [incubator-dubbo] chickenlj opened pull request #3847: Async
optimization, altanative to #3738.
## What is the purpose of the change
This pull request tries a different approach for achieving the same goal as #3738 by having Result extends CompletionStage and Future directly.
After finishing the code in this pull request, I strongly suggest using the way in #3738. Here are some drawbacks I found doing this PR:
1. CompletionStage is not convenient enough when programming, most of the time you will need CompletableFuture, but because Result itself is an Interface and most of the method uses Result instead of concrete Result class so you will only be able to interact with CompletionStage.
2. We only need very few callback methods provided by CompletionStage
## Brief changelog
XXXXX
## Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/incubator-dubbo/tree/master/dubbo-test).
- [x] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass.
- [x] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3847 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] chickenlj closed pull request #3847: Async
optimization, altanative to #3738.
Posted by "chickenlj (GitHub)" <gi...@apache.org>.
[ pull request closed by chickenlj ]
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3847 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org