You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/12/24 06:08:30 UTC
[GitHub] [ozone] amaliujia opened a new pull request #1733: [CI] Use single ratis server in MiniOzoneCluster tests for SCM
amaliujia opened a new pull request #1733:
URL: https://github.com/apache/ozone/pull/1733
## What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
## What is the link to the Apache JIRA
(Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HDDS-XXXX. Fix a typo in YYY.)
Please replace this section with the link to the Apache JIRA)
## How was this patch tested?
(Please explain how this patch was tested. Ex: unit tests, manual tests)
(If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] amaliujia commented on a change in pull request #1733: HDDS-4622. Use single ratis server in MiniOzoneCluster tests for SCM
Posted by GitBox <gi...@apache.org>.
amaliujia commented on a change in pull request #1733:
URL: https://github.com/apache/ozone/pull/1733#discussion_r548927953
##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMHAConfiguration.java
##########
@@ -38,7 +38,7 @@
@Config(key = "ratis.storage.dir",
type = ConfigType.STRING,
- defaultValue = "",
+ defaultValue = "scm-ratis",
Review comment:
We won't need this line of change after https://github.com/apache/ozone/pull/1739
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] GlenGeng commented on a change in pull request #1733: HDDS-4622. Use single ratis server in MiniOzoneCluster tests for SCM
Posted by GitBox <gi...@apache.org>.
GlenGeng commented on a change in pull request #1733:
URL: https://github.com/apache/ozone/pull/1733#discussion_r549125335
##########
File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/MiniOzoneClusterImpl.java
##########
@@ -169,17 +169,21 @@ public void waitForClusterToBeReady()
throws TimeoutException, InterruptedException {
GenericTestUtils.waitFor(() -> {
final int healthy = scm.getNodeCount(HEALTHY);
+ // When SCM HA is not enabled, scm is always leader.
+ final boolean checkScmLeader = scm.checkLeader();
Review comment:
Good!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] amaliujia commented on pull request #1733: HDDS-4622. Use single ratis server in MiniOzoneCluster tests for SCM
Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #1733:
URL: https://github.com/apache/ozone/pull/1733#issuecomment-751303592
cc: @GlenGeng
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] amaliujia closed pull request #1733: HDDS-4622. Use single ratis server in MiniOzoneCluster tests for SCM
Posted by GitBox <gi...@apache.org>.
amaliujia closed pull request #1733:
URL: https://github.com/apache/ozone/pull/1733
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] amaliujia commented on a change in pull request #1733: HDDS-4622. Use single ratis server in MiniOzoneCluster tests for SCM
Posted by GitBox <gi...@apache.org>.
amaliujia commented on a change in pull request #1733:
URL: https://github.com/apache/ozone/pull/1733#discussion_r548926123
##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMHAConfiguration.java
##########
@@ -38,7 +38,7 @@
@Config(key = "ratis.storage.dir",
type = ConfigType.STRING,
- defaultValue = "",
+ defaultValue = "scm-ratis",
Review comment:
This is workaround to config SCM ratis storage dir value. The usual way that config value in SCMHAConfiguration seems break. I will file a JIRA to fix it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] amaliujia commented on a change in pull request #1733: HDDS-4622. Use single ratis server in MiniOzoneCluster tests for SCM
Posted by GitBox <gi...@apache.org>.
amaliujia commented on a change in pull request #1733:
URL: https://github.com/apache/ozone/pull/1733#discussion_r548926617
##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMHAConfiguration.java
##########
@@ -38,7 +38,7 @@
@Config(key = "ratis.storage.dir",
type = ConfigType.STRING,
- defaultValue = "",
+ defaultValue = "scm-ratis",
Review comment:
https://issues.apache.org/jira/browse/HDDS-4624
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org