You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/05/07 20:49:55 UTC
[GitHub] [cloudstack-primate] nvazquez opened a new pull request #330: WIP: Add unmanage VM button
nvazquez opened a new pull request #330:
URL: https://github.com/apache/cloudstack-primate/pull/330
Add the Unmanage VM button on the instance view for VMware running VMs:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #330: Add unmanage VM button
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #330:
URL: https://github.com/apache/cloudstack-primate/pull/330#issuecomment-639263909
@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #330: Add unmanage VM button
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #330:
URL: https://github.com/apache/cloudstack-primate/pull/330#discussion_r434401407
##########
File path: src/config/section/compute.js
##########
@@ -319,6 +319,20 @@ export default {
dataView: true,
show: (record, store) => { return ['Destroyed'].includes(record.state) && store.features.allowuserexpungerecovervm }
},
+ {
+ api: 'unmanageVirtualMachine',
+ icon: 'disconnect',
+ label: 'label.action.unmanage.virtualmachine',
+ args: ['id'],
+ dataView: true,
+ groupAction: true,
+ show: (record) => { return ['Running', 'Stopped'].includes(record.state) && record.hypervisor === 'VMware' },
+ mapping: {
+ id: {
+ value: (record, params) => { return record.id }
Review comment:
we use mapping when the key is not the same as specified in the `args`, so this will still work without adding the mapping here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #330: Add unmanage VM button
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #330:
URL: https://github.com/apache/cloudstack-primate/pull/330#issuecomment-635182303
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. JID-1947
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd merged pull request #330: Add unmanage VM button
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #330:
URL: https://github.com/apache/cloudstack-primate/pull/330
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #330: Add unmanage VM button
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #330:
URL: https://github.com/apache/cloudstack-primate/pull/330#issuecomment-638048543
@nvazquez is this ready for review?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #330: Add unmanage VM button
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #330:
URL: https://github.com/apache/cloudstack-primate/pull/330#issuecomment-639263602
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #330: Add unmanage VM button
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #330:
URL: https://github.com/apache/cloudstack-primate/pull/330#issuecomment-635110792
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. JID-1946
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org