You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zookeeper.apache.org by fp...@apache.org on 2014/11/19 23:39:20 UTC
svn commit: r1640637 - in /zookeeper/branches/branch-3.4: CHANGES.txt
src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java
Author: fpj
Date: Wed Nov 19 22:39:20 2014
New Revision: 1640637
URL: http://svn.apache.org/r1640637
Log:
ZOOKEEPER-2060 Trace bug in NettyServerCnxnFactory (Ian via fpj)
Modified:
zookeeper/branches/branch-3.4/CHANGES.txt
zookeeper/branches/branch-3.4/src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java
Modified: zookeeper/branches/branch-3.4/CHANGES.txt
URL: http://svn.apache.org/viewvc/zookeeper/branches/branch-3.4/CHANGES.txt?rev=1640637&r1=1640636&r2=1640637&view=diff
==============================================================================
--- zookeeper/branches/branch-3.4/CHANGES.txt (original)
+++ zookeeper/branches/branch-3.4/CHANGES.txt Wed Nov 19 22:39:20 2014
@@ -51,6 +51,8 @@ BUGFIXES:
ZOOKEEPER-2052 Unable to delete a node when the node has no children
(Hongchao Deng and Yip Ng via rakeshr)
+
+ ZOOKEEPER-2060 Trace bug in NettyServerCnxnFactory (Ian via fpj)
IMPROVEMENTS:
Modified: zookeeper/branches/branch-3.4/src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java
URL: http://svn.apache.org/viewvc/zookeeper/branches/branch-3.4/src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java?rev=1640637&r1=1640636&r2=1640637&view=diff
==============================================================================
--- zookeeper/branches/branch-3.4/src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java (original)
+++ zookeeper/branches/branch-3.4/src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java Wed Nov 19 22:39:20 2014
@@ -182,9 +182,11 @@ public class NettyServerCnxnFactory exte
cnxn.queuedBuffer = dynamicBuffer(buf.readableBytes());
}
cnxn.queuedBuffer.writeBytes(buf);
- LOG.debug(Long.toHexString(cnxn.sessionId)
- + " queuedBuffer 0x"
- + ChannelBuffers.hexDump(cnxn.queuedBuffer));
+ if (LOG.isTraceEnabled()) {
+ LOG.trace(Long.toHexString(cnxn.sessionId)
+ + " queuedBuffer 0x"
+ + ChannelBuffers.hexDump(cnxn.queuedBuffer));
+ }
} else {
LOG.debug("not throttled");
if (cnxn.queuedBuffer != null) {