[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac

[GitBox <gi...@apache.org>]

apeforest commented on a change in pull request #14535: [DOC] Updated install instructions for mac
URL: https://github.com/apache/incubator-mxnet/pull/14535#discussion_r273149044
 
 

 ##########
 File path: docs/install/osx_setup.md
 ##########
 @@ -100,14 +104,21 @@ After you have installed the dependencies, pull the MXNet source code from Git a
 The file called ```osx.mk``` has the configuration required for building MXNet on OS X. First copy ```make/osx.mk``` into ```config.mk```, which is used by the ```make``` command:
 
 ```bash
-    git clone --recursive https://github.com/apache/incubator-mxnet ~/mxnet
-    cd ~/mxnet
-    cp make/osx.mk ./config.mk
-    echo "USE_BLAS = openblas" >> ./config.mk
-    echo "ADD_CFLAGS += -I/usr/local/opt/openblas/include" >> ./config.mk
-    echo "ADD_LDFLAGS += -L/usr/local/opt/openblas/lib" >> ./config.mk
-    echo "ADD_LDFLAGS += -L/usr/local/lib/graphviz/" >> ./config.mk
-    make -j$(sysctl -n hw.ncpu)
+git clone --recursive https://github.com/apache/incubator-mxnet ~/mxnet
+cd ~/mxnet
+mkdir build && cd build
+cmake \
+    -DCMAKE_CXX_COMPILER_LAUNCHER=ccache \
 
 Review comment:
   While `ccache` is really tool for speeding up the compilation time, I still feel we should just provide the minimum required steps for users to build mxnet. Can we suggest these performance tools in a separate doc/section?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services