You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@weex.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/11/14 05:16:00 UTC
[jira] [Commented] (WEEX-112) Weex playground adapt to iPhone X
[ https://issues.apache.org/jira/browse/WEEX-112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16250881#comment-16250881 ]
ASF GitHub Bot commented on WEEX-112:
-------------------------------------
GitHub user acton393 opened a pull request:
https://github.com/apache/incubator-weex/pull/860
[WEEX-112][iOS] make weex playground app adapt to iPhone X
according to https://developer.apple.com/ios/human-interface-guidelines/icons-and-images/launch-screen/ ,
we must add a 1125px X 2436px launch image for Portrait size and 2436 X1125px, at the same time,
developers must consider about the safe-area of container.
Bug: 112
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/acton393/incubator-weex weexplayground-adapte-iPhoneX
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/860.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #860
----
commit f2fbd72aaf3043712eff233c06bcb242f6382a31
Author: acton393 <zh...@gmail.com>
Date: 2017-11-14T05:10:15Z
[WEEX-112][iOS] make weex playground app adapt to iPhone X
according to https://developer.apple.com/ios/human-interface-guidelines/icons-and-images/launch-screen/ ,
we must add a 1125px X 2436px launch image for Portrait size and 2436 X1125px, at the same time,
developers must consider about the safe-area of container.
Bug: 112
----
> Weex playground adapt to iPhone X
> ---------------------------------
>
> Key: WEEX-112
> URL: https://issues.apache.org/jira/browse/WEEX-112
> Project: Weex
> Issue Type: Bug
> Reporter: xingZhang
> Assignee: Adam Feng
>
> As weex view container must consider about the view safe area.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)