[GitHub] [tvm] driazati commented on pull request #10758: Manually add libtorch op test

[GitBox <gi...@apache.org>]

driazati commented on PR #10758:
URL: https://github.com/apache/tvm/pull/10758#issuecomment-1111578204

   sorry for my delays, I was able to repro the error using `tests/scripts/ci.py`:
   
   ```bash
   gh pr checkout -f 10758
   # errors out
   python tests/scripts/ci.py gpu
   ```
   
   upgrading to cmake 3.11.4 (via this patch to `ci.py`) seems to fix it and the build finishes successfully though
   
   ```diff
   diff --git a/tests/scripts/ci.py b/tests/scripts/ci.py
   index c0ce085ff..4ee9725e7 100755
   --- a/tests/scripts/ci.py
   +++ b/tests/scripts/ci.py
   @@ -370,10 +370,22 @@ def generate_command(
            if precheck is not None:
                precheck()
    
   +        cmake_stuff = [
   +            "sudo apt remove -y cmake",
   +            "rm -rf CMake",
   +            "git clone --branch v3.11.4 https://github.com/Kitware/CMake.git --depth=1",
   +            "pushd CMake",
   +            "./configure --parallel=24",
   +            "make -j24",
   +            "sudo ln -s $(pwd)/bin/cmake /usr/bin/cmake",
   +            "popd",
   +            "cmake --version",
   +        ]
   +
            if skip_build:
                scripts = []
            else:
   -            scripts = [
   +            scripts = cmake_stuff + [
                    f"./tests/scripts/task_config_build_{name}.sh {get_build_dir(name)}",
                    f"./tests/scripts/task_build.py --build-dir {get_build_dir(name)}",
                    # This can be removed once https://github.com/apache/tvm/pull/10257
   ```
   then re-running 
   
   ```bash
   tests/scripts/ci.py gpu
   ```
   
   so upgrading cmake to 3.11.4 in CI seems like the best way to go (we're on 3.10 right now), so @t-vi if `ubuntu_install_cmake_source.sh` builds cmake `3.11.4` that'd be good


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org