You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2012/08/03 19:42:59 UTC

Re: Review Request: Add a module in slave to collect resource usage information.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5715/
-----------------------------------------------------------

(Updated Aug. 3, 2012, 5:42 p.m.)


Review request for mesos and Benjamin Hindman.


Changes
-------

Cleanup the code. Fixed format issues. Integrate changes that are not in the previous patch.


Description
-------

Add a module in slave to collet resource usage information.

The isolation module should implement the interface class ResourceStatisticsCollector so that ResourceUsageProcess can pull information from it.

Each instance of ResourceStatistics is a snapshot about the resource usage of an entity (either an executor, or an process).

ResourceMeter is an abstract class that defines the measurement of resource usage. Each subclass of ResourceUsageMeter defines a specific measurement of resource usage (e.g. maxRSS, avgCpuUsage, etc.)


Diffs (updated)
-----

  src/Makefile.am 10f1101 
  src/slave/statistics.hpp PRE-CREATION 
  src/slave/statistics.cpp PRE-CREATION 
  src/tests/statistics_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/5715/diff/


Testing
-------

Make check.

Tested on Linux. Mac implementation pending.


Thanks,

Jie Yu