You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Branko Čibej <br...@xbc.nu> on 2004/07/01 17:52:22 UTC
Re: svn commit: r10114 - in trunk: . subversion/include subversion/libsvn_client
subversion/libsvn_subr subversion/libsvn_wc subversion/tests/clients/cmdline
jpieper@tigris.org wrote:
>+ /* On Win32, CreateFile failswith an "Access Denied" error
>+ code, rather than "File Already Exists", if the colliding
>+ name belongs to a directory. */
>
>
Isn't this Win32-specific comment inside an '#ifdef HAVE_SYMLINK'
somewhat strange?
-- Brane
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r10114 - in trunk: . subversion/include subversion/libsvn_client
subversion/libsvn_subr subversion/libsvn_wc subversion/tests/clients/cmdline
Posted by Branko Čibej <br...@xbc.nu>.
Josh Pieper wrote:
>Branko ??ibej wrote:
>
>
>>jpieper@tigris.org wrote:
>>
>>
>>
>>>+ /* On Win32, CreateFile failswith an "Access Denied" error
>>>+ code, rather than "File Already Exists", if the colliding
>>>+ name belongs to a directory. */
>>>
>>>
>>>
>>>
>>Isn't this Win32-specific comment inside an '#ifdef HAVE_SYMLINK'
>>somewhat strange?
>>
>>
>
>Well, I believe it was you who said we should test for features, not
>platforms. There might be some platform that supports symlinks, but
>does return the access denied error...
>
>
Hm. O.K.
We're going to have to solve this platform-specific mess in a more
consistent way soon. We're piling hacks upon hacks. Yah. Seems to me we
need a portability guideline document (or section in HACKING). There are
some things APR simply isn't intended to handle.
-- Brane
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r10114 - in trunk: . subversion/include subversion/libsvn_client subversion/libsvn_subr subversion/libsvn_wc subversion/tests/clients/cmdline
Posted by Josh Pieper <jj...@pobox.com>.
Branko ??ibej wrote:
> jpieper@tigris.org wrote:
>
> >+ /* On Win32, CreateFile failswith an "Access Denied" error
> >+ code, rather than "File Already Exists", if the colliding
> >+ name belongs to a directory. */
> >
> >
> Isn't this Win32-specific comment inside an '#ifdef HAVE_SYMLINK'
> somewhat strange?
Well, I believe it was you who said we should test for features, not
platforms. There might be some platform that supports symlinks, but
does return the access denied error...
-Josh
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org