You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/05/12 15:33:02 UTC
[GitHub] [iotdb] qiaojialin commented on a diff in pull request #5811: [IOTDB-2919] Feature/Delete storage group
qiaojialin commented on code in PR #5811:
URL: https://github.com/apache/iotdb/pull/5811#discussion_r871501698
##########
confignode/src/main/java/org/apache/iotdb/confignode/conf/ConfigNodeConstant.java:
##########
@@ -42,6 +42,7 @@ public class ConfigNodeConstant {
public static final String DATA_DIR = "data";
public static final String CONF_DIR = "conf";
public static final String CONSENSUS_FOLDER = "consensus";
+ public static final String PROCEDURE_FOLDER = "proc";
Review Comment:
How about storing this under the system folder, reducing a parameter for users
Besides, we could rename this to procedure, proc looks like process...
##########
confignode/src/assembly/resources/conf/iotdb-confignode.properties:
##########
@@ -194,4 +194,33 @@ target_confignode=0.0.0.0:22277
# consensus_dir=data\\consensus
# For Linux platform
# If its prefix is "/", then the path is absolute. Otherwise, it is relative.
-# consensus_dir=data/consensus
\ No newline at end of file
+# consensus_dir=data/consensus
+
+# procedure wal dir
+# If this property is unset, system will save the data in the default relative path directory under the confignode folder(i.e., %CONFIGNODE_HOME%/data/consensus).
+# If it is absolute, system will save the data in exact location it points to.
+# If it is relative, system will save the data in the relative path directory it indicates under the confignode folder.
+# Note: If data_dir is assigned an empty string(i.e.,zero-size), it will be handled as a relative path.
+# For windows platform
+# If its prefix is a drive specifier followed by "\\", or if its prefix is "\\\\", then the path is absolute. Otherwise, it is relative.
+# proc_wal_dir=data\\proc
+# For Linux platform
+# If its prefix is "/", then the path is absolute. Otherwise, it is relative.
+# proc_wal_dir=data/proc
+####################
+### Procedure Configuration
+####################
+
+# Default number of worker thread count
+# Datatype: int
+#workerthreads_core_size=4
+
+# Default time interval of completed procedure cleaner work in, time unit is second
+# Datatype: int
+#completed_clean_interval=30
Review Comment:
```suggestion
#procedure_completed_clean_interval=30
```
##########
confignode/src/assembly/resources/conf/iotdb-confignode.properties:
##########
@@ -194,4 +194,33 @@ target_confignode=0.0.0.0:22277
# consensus_dir=data\\consensus
# For Linux platform
# If its prefix is "/", then the path is absolute. Otherwise, it is relative.
-# consensus_dir=data/consensus
\ No newline at end of file
+# consensus_dir=data/consensus
+
+# procedure wal dir
+# If this property is unset, system will save the data in the default relative path directory under the confignode folder(i.e., %CONFIGNODE_HOME%/data/consensus).
+# If it is absolute, system will save the data in exact location it points to.
+# If it is relative, system will save the data in the relative path directory it indicates under the confignode folder.
+# Note: If data_dir is assigned an empty string(i.e.,zero-size), it will be handled as a relative path.
+# For windows platform
+# If its prefix is a drive specifier followed by "\\", or if its prefix is "\\\\", then the path is absolute. Otherwise, it is relative.
+# proc_wal_dir=data\\proc
+# For Linux platform
+# If its prefix is "/", then the path is absolute. Otherwise, it is relative.
+# proc_wal_dir=data/proc
+####################
+### Procedure Configuration
+####################
+
+# Default number of worker thread count
+# Datatype: int
+#workerthreads_core_size=4
Review Comment:
```suggestion
#procedure_workerthreads_core_size=4
```
##########
confignode/src/main/java/org/apache/iotdb/confignode/consensus/request/write/DeleteStorageGroupsReq.java:
##########
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.iotdb.confignode.consensus.request.write;
+
+import java.util.List;
+import java.util.Objects;
+
+public class DeleteStorageGroupsReq {
Review Comment:
Better to distinguish between requests that send to consensus and those sent to the procedure.
We could rename this to DeleteStorageGroupsProcedureParameter or so
##########
confignode/src/assembly/resources/conf/iotdb-confignode.properties:
##########
@@ -194,4 +194,33 @@ target_confignode=0.0.0.0:22277
# consensus_dir=data\\consensus
# For Linux platform
# If its prefix is "/", then the path is absolute. Otherwise, it is relative.
-# consensus_dir=data/consensus
\ No newline at end of file
+# consensus_dir=data/consensus
+
+# procedure wal dir
+# If this property is unset, system will save the data in the default relative path directory under the confignode folder(i.e., %CONFIGNODE_HOME%/data/consensus).
+# If it is absolute, system will save the data in exact location it points to.
+# If it is relative, system will save the data in the relative path directory it indicates under the confignode folder.
+# Note: If data_dir is assigned an empty string(i.e.,zero-size), it will be handled as a relative path.
+# For windows platform
+# If its prefix is a drive specifier followed by "\\", or if its prefix is "\\\\", then the path is absolute. Otherwise, it is relative.
+# proc_wal_dir=data\\proc
+# For Linux platform
+# If its prefix is "/", then the path is absolute. Otherwise, it is relative.
+# proc_wal_dir=data/proc
+####################
+### Procedure Configuration
+####################
+
+# Default number of worker thread count
+# Datatype: int
+#workerthreads_core_size=4
+
+# Default time interval of completed procedure cleaner work in, time unit is second
+# Datatype: int
+#completed_clean_interval=30
+
+
+# Default ttl of completed procedure, time unit is second
+# Datatype: int
+#completed_evict_ttl=800
Review Comment:
```suggestion
#procedure_completed_evict_ttl=800
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org