You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "sam-byng (via GitHub)" <gi...@apache.org> on 2023/04/25 11:37:15 UTC

[GitHub] [incubator-pekko-samples] sam-byng opened a new pull request, #40: Use pekko paradox

sam-byng opened a new pull request, #40:
URL: https://github.com/apache/incubator-pekko-samples/pull/40

   Fixes #35 
   
   tested locally - success:
   ```
   sbt paradox
   start pekko-sample-cluster-scala/target/paradox/site/main/index.html
   ```
   ![image](https://user-images.githubusercontent.com/43856946/234264599-cabd4866-e27f-4712-82fa-4620f1e21dfd.png)
   
   I've also reformatted the input to projectSettings so that they're easier to interpret


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


[GitHub] [incubator-pekko-samples] pjfanning merged pull request #40: #35 : Use pekko paradox

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #40:
URL: https://github.com/apache/incubator-pekko-samples/pull/40


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


[GitHub] [incubator-pekko-samples] pjfanning commented on a diff in pull request #40: #35 : Use pekko paradox

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #40:
URL: https://github.com/apache/incubator-pekko-samples/pull/40#discussion_r1176393327


##########
docs-gen/project/plugins.sbt:
##########
@@ -1,8 +1,4 @@
 // allow access to snapshots for pekko-sbt-paradox
 resolvers += "Apache Nexus Snapshots".at("https://repository.apache.org/content/repositories/snapshots/")
 
-// We have to deliberately use older versions of sbt-paradox because current Pekko sbt build
-// only loads on JDK 1.8 so we need to bring in older versions of parboiled which support JDK 1.8
-addSbtPlugin(("org.apache.pekko" % "pekko-sbt-paradox" % "0.0.0+30-8bee46d0-SNAPSHOT").excludeAll(
-  "com.lightbend.paradox", "sbt-paradox"))
-addSbtPlugin(("com.lightbend.paradox" % "sbt-paradox" % "0.9.2").force())
+addSbtPlugin("org.apache.pekko" % "pekko-sbt-paradox" % "0.0.0+30-8bee46d0-SNAPSHOT")

Review Comment:
   could you upgrade the plugin? 0.0.0+39-1df580ce-SNAPSHOT
   
   https://repository.apache.org/content/groups/snapshots/org/apache/pekko/pekko-sbt-paradox_2.12_1.0/



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


[GitHub] [incubator-pekko-samples] sam-byng commented on a diff in pull request #40: #35 : Use pekko paradox

Posted by "sam-byng (via GitHub)" <gi...@apache.org>.
sam-byng commented on code in PR #40:
URL: https://github.com/apache/incubator-pekko-samples/pull/40#discussion_r1176467346


##########
docs-gen/project/plugins.sbt:
##########
@@ -1,8 +1,4 @@
 // allow access to snapshots for pekko-sbt-paradox
 resolvers += "Apache Nexus Snapshots".at("https://repository.apache.org/content/repositories/snapshots/")
 
-// We have to deliberately use older versions of sbt-paradox because current Pekko sbt build
-// only loads on JDK 1.8 so we need to bring in older versions of parboiled which support JDK 1.8
-addSbtPlugin(("org.apache.pekko" % "pekko-sbt-paradox" % "0.0.0+30-8bee46d0-SNAPSHOT").excludeAll(
-  "com.lightbend.paradox", "sbt-paradox"))
-addSbtPlugin(("com.lightbend.paradox" % "sbt-paradox" % "0.9.2").force())
+addSbtPlugin("org.apache.pekko" % "pekko-sbt-paradox" % "0.0.0+30-8bee46d0-SNAPSHOT")

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org