[I] serversocket.cpp fails to compile with MSVC v141 — unqualified LogString (missing using namespace LOG4CXX_NS;) [logging-log4cxx]

["qjoyel (via GitHub)" <gi...@apache.org>]

qjoyel opened a new issue, #718:
URL: https://github.com/apache/logging-log4cxx/issues/718

   File: src/main/cpp/serversocket.cpp ([L60](https://github.com/apache/logging-log4cxx/blob/cb42be773a60031956e8138ab83744a87d6184c6/src/main/cpp/serversocket.cpp#L60)). Affects versions > 1.4.0
   
   The file only does using namespace LOG4CXX_NS::helpers;, but LogString lives in the parent namespace LOG4CXX_NS and is used unqualified in ServerSocket::create(). Stricter compilers fail to resolve it.
   
   Environment: MSVC 19.16.27054.0, toolset v141 (host x86), Win32, Windows SDK 10.0.19041.0, C++17.
   
   Fix: add the parent namespace:
   ```
   using namespace LOG4CXX_NS;
   using namespace LOG4CXX_NS::helpers;
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] serversocket.cpp fails to compile with MSVC v141 — unqualified LogString (missing using namespace LOG4CXX_NS;) [logging-log4cxx]

["swebb2066 (via GitHub)" <gi...@apache.org>]

swebb2066 closed issue #718: serversocket.cpp fails to compile with MSVC v141 — unqualified LogString (missing using namespace LOG4CXX_NS;)
URL: https://github.com/apache/logging-log4cxx/issues/718


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org