You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/12/14 18:44:14 UTC

[GitHub] [kafka] wcarlson5 commented on a change in pull request #11600: KAFKA-12648: handle MissingSourceTopicException for named topologies

wcarlson5 commented on a change in pull request #11600:
URL: https://github.com/apache/kafka/pull/11600#discussion_r768947553



##########
File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TopologyMetadata.java
##########
@@ -436,9 +436,25 @@ public String getStoreForChangelogTopic(final String topicName) {
         return sourceTopics;
     }
 
-    public Map<Subtopology, TopicsInfo> topicGroups() {
+    /**
+     * @param topologiesToExclude the names of any topologies to exclude from the returned topic groups,
+     *                            eg because they have missing source topics and can't be processed yet
+     */
+    public Map<Subtopology, TopicsInfo> topicGroups(final Set<String> topologiesToExclude) {

Review comment:
       nit: can we update the name to be more descriptive?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org