You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/10/27 01:24:44 UTC
[GitHub] [apisix-dashboard] liuxiran opened a new issue #605: discuss: how to get different type of plugin schema in 2.0 manager-api
liuxiran opened a new issue #605:
URL: https://github.com/apache/apisix-dashboard/issues/605
Please answer these questions before submitting your issue.
- Why do you submit this issue?
- [ ] Question or discussion
- [ ] Bug
- [ ] Requirements
- [ ] Feature or performance improvement
- [ ] Other
___
### Premise
Refered to https://github.com/apache/apisix/issues/2441#issuecomment-714330623, we are tring to implement the feature, that getting different plugin schema by schema type through query params.
After refactoring, manager-api will get the plugin schema via [schema.json](https://github.com/apache/apisix-dashboard/blob/v2.0/api/conf/schema.json), which is generated by [schema-sync.sh](https://github.com/apache/apisix-dashboard/blob/v2.0/api/build-tools/schema-sync.sh) and [schema-sync.lua](https://github.com/apache/apisix-dashboard/blob/v2.0/api/build-tools/schema-sync.lua) instead of getting directly from admin-api
### Question
Is it possible to add this query param in 2.0 manager-api？
- change the plugin schema generated by `schema-sync.sh` and `schema-sync.lua` ?
- some other way?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] moonming commented on issue #605: discuss: how to get different type of plugin schema in 2.0 manager-api
Posted by GitBox <gi...@apache.org>.
moonming commented on issue #605:
URL: https://github.com/apache/apisix-dashboard/issues/605#issuecomment-727785692
@nic-chen will you lead this feature? We have reached a consensus on the mailing list
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis edited a comment on issue #605: discuss: how to get different type of plugin schema in 2.0 manager-api
Posted by GitBox <gi...@apache.org>.
membphis edited a comment on issue #605:
URL: https://github.com/apache/apisix-dashboard/issues/605#issuecomment-729022532
@nic-chen do we will implement this feature in milestone `2.2`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on issue #605: discuss: how to get different type of plugin schema in 2.0 manager-api
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #605:
URL: https://github.com/apache/apisix-dashboard/issues/605#issuecomment-729022532
@nic-chen do we will implement this feature in version `2.2`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on issue #605: discuss: how to get different type of plugin schema in 2.0 manager-api
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #605:
URL: https://github.com/apache/apisix-dashboard/issues/605#issuecomment-735712372
> @membphis
> I think we could move it to 2.2
> what do you think?
agree, and set the milestone to `2.2`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #605: discuss: how to get different type of plugin schema in 2.0 manager-api
Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #605:
URL: https://github.com/apache/apisix-dashboard/issues/605#issuecomment-716955558
@liuxiran
I think we need to update two files:
1. update `schema-sync.lua` so that it can sync all types schemas.
2. update `internal/handler/plugin/plugin.go` so that it can get different plugin schema by type through query params
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen closed issue #605: discuss: how to get different type of plugin schema in 2.0 manager-api
Posted by GitBox <gi...@apache.org>.
nic-chen closed issue #605:
URL: https://github.com/apache/apisix-dashboard/issues/605
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on issue #605: discuss: how to get different type of plugin schema in 2.0 manager-api
Posted by GitBox <gi...@apache.org>.
liuxiran commented on issue #605:
URL: https://github.com/apache/apisix-dashboard/issues/605#issuecomment-716980295
> @liuxiran
>
> I think we need to update two files:
>
> 1. update `schema-sync.lua` so that it can sync all types schemas.
>
> 2. update `internal/handler/plugin/plugin.go` so that it can get different plugin schema by type through query params
Thx for your feedback @nic-chen :), when the feature done, I`ll update the comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #605: discuss: how to get different type of plugin schema in 2.0 manager-api
Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #605:
URL: https://github.com/apache/apisix-dashboard/issues/605#issuecomment-716957534
we could do this after the feature you mentioned is done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #605: discuss: how to get different type of plugin schema in 2.0 manager-api
Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #605:
URL: https://github.com/apache/apisix-dashboard/issues/605#issuecomment-727787370
> @nic-chen will you lead this feature? We have reached a consensus on the mailing list
yes, of course.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on issue #605: discuss: how to get different type of plugin schema in 2.0 manager-api
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #605:
URL: https://github.com/apache/apisix-dashboard/issues/605#issuecomment-732765130
related issue: https://github.com/apache/apisix/issues/2700
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on issue #605: discuss: how to get different type of plugin schema in 2.0 manager-api
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #605:
URL: https://github.com/apache/apisix-dashboard/issues/605#issuecomment-720894800
welcome to discuss this in mail list:
https://lists.apache.org/thread.html/r83f31a15112b66e849ea28e073d11962dee77e5eb928c4f1e8deac10%40%3Cdev.apisix.apache.org%3E
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] moonming commented on issue #605: discuss: how to get different type of plugin schema in 2.0 manager-api
Posted by GitBox <gi...@apache.org>.
moonming commented on issue #605:
URL: https://github.com/apache/apisix-dashboard/issues/605#issuecomment-720862188
@liuxiran @nic-chen
I have been busy during this period and I did not see this issue. Welcome to post this kind of important discussion to the mailing list.
Going back to the problem of synchronization schema, what I hope to achieve in the end is:
1. The tool for synchronizing schema has nothing to do with the dashboard project. After all, this is a product that the data plane should generate;
2. When the schema of the data plane changes, there is no need to modify the code of this tool;
3. The dashboard project should not depend on Lua.
What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on issue #605: discuss: how to get different type of plugin schema in 2.0 manager-api
Posted by GitBox <gi...@apache.org>.
liuxiran commented on issue #605:
URL: https://github.com/apache/apisix-dashboard/issues/605#issuecomment-716917346
cc @juzhiyuan @nic-chen @ShiningRush
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #605: discuss: how to get different type of plugin schema in 2.0 manager-api
Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #605:
URL: https://github.com/apache/apisix-dashboard/issues/605#issuecomment-735708889
@membphis
I think we could move it to 2.2
what do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #605: discuss: how to get different type of plugin schema in 2.0 manager-api
Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #605:
URL: https://github.com/apache/apisix-dashboard/issues/605#issuecomment-729405247
> @nic-chen do we will implement this feature in milestone `2.2`?
sure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org