You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@corinthia.apache.org by or...@apache.org on 2015/08/09 18:26:00 UTC
[2/2] incubator-corinthia git commit: Note on iconv dependencies
Note on iconv dependencies
Result of a grep search for iconv.h dependencies. (Included by mistake,
but perhaps useful in review.)
Project: http://git-wip-us.apache.org/repos/asf/incubator-corinthia/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-corinthia/commit/75ef795d
Tree: http://git-wip-us.apache.org/repos/asf/incubator-corinthia/tree/75ef795d
Diff: http://git-wip-us.apache.org/repos/asf/incubator-corinthia/diff/75ef795d
Branch: refs/heads/master
Commit: 75ef795dd7cbe036f9eaf924cb72f513bf648cca
Parents: 002851b
Author: Dennis Hamilton <or...@apache.org>
Authored: Sun Aug 9 09:25:46 2015 -0700
Committer: Dennis Hamilton <or...@apache.org>
Committed: Sun Aug 9 09:25:46 2015 -0700
----------------------------------------------------------------------
iconv.txt | 29 +++++++++++++++++++++++++++++
1 file changed, 29 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-corinthia/blob/75ef795d/iconv.txt
----------------------------------------------------------------------
diff --git a/iconv.txt b/iconv.txt
new file mode 100644
index 0000000..f3ec07e
--- /dev/null
+++ b/iconv.txt
@@ -0,0 +1,29 @@
+*** (orcmid). I did a grep to find all of the places that have an iconv.h
+*** dependency. These are what I found. Note that inconv.h shows up as an
+*** optional dependency of some externals and there are ways to exclude it.
+
+./DocFormats/platform/3rdparty/w3c-tidy-html5/src/iconvtc.c:#include <iconv.h>
+
+Binary file ./external/download/iconv-1.9.2.win32.zip matches
+
+./external/download/include/iconv.h:/* When installed, this file is called
+ "iconv.h". */
+
+./external/download/include/iconv.h: errors because some other system header
+ file includes /usr/include/iconv.h
+
+./external/download/include/iconv.h: But gcc's #include_next is not
+ portable. Thus, once libiconv's iconv.h
+
+./external/download/include/iconv.h: include the original
+ /usr/include/iconv.h. We simply have to get away
+
+./external/download/include/iconv.h: #include "iconv.h" or #include_next
+ "iconv.h"
+
+./external/download/include/iconv.h: is small. They all do #include
+ <iconv.h>.
+
+./external/download/include/libxml/encoding.h:#include <iconv.h>
+
+./external/download/include/SDL_stdinc.h:# include <iconv.h>
Re: [2/2] incubator-corinthia git commit: Note on iconv dependencies
Posted by jan i <ja...@apache.org>.
I do not understand the purpose of this file ?
I do understand that you have been searching, which is good, but why add it
as a file to our repo ?
rgds
jan i.
On 9 August 2015 at 18:26, <or...@apache.org> wrote:
> Note on iconv dependencies
>
> Result of a grep search for iconv.h dependencies. (Included by mistake,
> but perhaps useful in review.)
>
>
> Project: http://git-wip-us.apache.org/repos/asf/incubator-corinthia/repo
> Commit:
> http://git-wip-us.apache.org/repos/asf/incubator-corinthia/commit/75ef795d
> Tree:
> http://git-wip-us.apache.org/repos/asf/incubator-corinthia/tree/75ef795d
> Diff:
> http://git-wip-us.apache.org/repos/asf/incubator-corinthia/diff/75ef795d
>
> Branch: refs/heads/master
> Commit: 75ef795dd7cbe036f9eaf924cb72f513bf648cca
> Parents: 002851b
> Author: Dennis Hamilton <or...@apache.org>
> Authored: Sun Aug 9 09:25:46 2015 -0700
> Committer: Dennis Hamilton <or...@apache.org>
> Committed: Sun Aug 9 09:25:46 2015 -0700
>
> ----------------------------------------------------------------------
> iconv.txt | 29 +++++++++++++++++++++++++++++
> 1 file changed, 29 insertions(+)
> ----------------------------------------------------------------------
>
>
>
> http://git-wip-us.apache.org/repos/asf/incubator-corinthia/blob/75ef795d/iconv.txt
> ----------------------------------------------------------------------
> diff --git a/iconv.txt b/iconv.txt
> new file mode 100644
> index 0000000..f3ec07e
> --- /dev/null
> +++ b/iconv.txt
> @@ -0,0 +1,29 @@
> +*** (orcmid). I did a grep to find all of the places that have an iconv.h
> +*** dependency. These are what I found. Note that inconv.h shows up as
> an
> +*** optional dependency of some externals and there are ways to exclude
> it.
> +
> +./DocFormats/platform/3rdparty/w3c-tidy-html5/src/iconvtc.c:#include
> <iconv.h>
> +
> +Binary file ./external/download/iconv-1.9.2.win32.zip matches
> +
> +./external/download/include/iconv.h:/* When installed, this file is called
> + "iconv.h". */
> +
> +./external/download/include/iconv.h: errors because some other system
> header
> + file includes /usr/include/iconv.h
> +
> +./external/download/include/iconv.h: But gcc's #include_next is not
> + portable. Thus, once libiconv's iconv.h
> +
> +./external/download/include/iconv.h: include the original
> + /usr/include/iconv.h. We simply have to get away
> +
> +./external/download/include/iconv.h: #include "iconv.h" or
> #include_next
> + "iconv.h"
> +
> +./external/download/include/iconv.h: is small. They all do #include
> + <iconv.h>.
> +
> +./external/download/include/libxml/encoding.h:#include <iconv.h>
> +
> +./external/download/include/SDL_stdinc.h:# include <iconv.h>
>
>
Re: [2/2] incubator-corinthia git commit: Note on iconv dependencies
Posted by jan i <ja...@apache.org>.
I do not understand the purpose of this file ?
I do understand that you have been searching, which is good, but why add it
as a file to our repo ?
rgds
jan i.
On 9 August 2015 at 18:26, <or...@apache.org> wrote:
> Note on iconv dependencies
>
> Result of a grep search for iconv.h dependencies. (Included by mistake,
> but perhaps useful in review.)
>
>
> Project: http://git-wip-us.apache.org/repos/asf/incubator-corinthia/repo
> Commit:
> http://git-wip-us.apache.org/repos/asf/incubator-corinthia/commit/75ef795d
> Tree:
> http://git-wip-us.apache.org/repos/asf/incubator-corinthia/tree/75ef795d
> Diff:
> http://git-wip-us.apache.org/repos/asf/incubator-corinthia/diff/75ef795d
>
> Branch: refs/heads/master
> Commit: 75ef795dd7cbe036f9eaf924cb72f513bf648cca
> Parents: 002851b
> Author: Dennis Hamilton <or...@apache.org>
> Authored: Sun Aug 9 09:25:46 2015 -0700
> Committer: Dennis Hamilton <or...@apache.org>
> Committed: Sun Aug 9 09:25:46 2015 -0700
>
> ----------------------------------------------------------------------
> iconv.txt | 29 +++++++++++++++++++++++++++++
> 1 file changed, 29 insertions(+)
> ----------------------------------------------------------------------
>
>
>
> http://git-wip-us.apache.org/repos/asf/incubator-corinthia/blob/75ef795d/iconv.txt
> ----------------------------------------------------------------------
> diff --git a/iconv.txt b/iconv.txt
> new file mode 100644
> index 0000000..f3ec07e
> --- /dev/null
> +++ b/iconv.txt
> @@ -0,0 +1,29 @@
> +*** (orcmid). I did a grep to find all of the places that have an iconv.h
> +*** dependency. These are what I found. Note that inconv.h shows up as
> an
> +*** optional dependency of some externals and there are ways to exclude
> it.
> +
> +./DocFormats/platform/3rdparty/w3c-tidy-html5/src/iconvtc.c:#include
> <iconv.h>
> +
> +Binary file ./external/download/iconv-1.9.2.win32.zip matches
> +
> +./external/download/include/iconv.h:/* When installed, this file is called
> + "iconv.h". */
> +
> +./external/download/include/iconv.h: errors because some other system
> header
> + file includes /usr/include/iconv.h
> +
> +./external/download/include/iconv.h: But gcc's #include_next is not
> + portable. Thus, once libiconv's iconv.h
> +
> +./external/download/include/iconv.h: include the original
> + /usr/include/iconv.h. We simply have to get away
> +
> +./external/download/include/iconv.h: #include "iconv.h" or
> #include_next
> + "iconv.h"
> +
> +./external/download/include/iconv.h: is small. They all do #include
> + <iconv.h>.
> +
> +./external/download/include/libxml/encoding.h:#include <iconv.h>
> +
> +./external/download/include/SDL_stdinc.h:# include <iconv.h>
>
>