You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by te...@apache.org on 2009/08/11 22:51:35 UTC
svn commit: r803292 - in /tapestry/tapestry5/trunk/tapestry-core/src/main:
java/org/apache/tapestry5/MarkupConstants.java
resources/org/apache/tapestry5/tapestry.js
Author: tedst
Date: Tue Aug 11 20:51:35 2009
New Revision: 803292
URL: http://svn.apache.org/viewvc?rev=803292&view=rev
Log:
TAP5-719: Component LinkSubmit doesn't work
Modified:
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/MarkupConstants.java
tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/tapestry.js
Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/MarkupConstants.java
URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/MarkupConstants.java?rev=803292&r1=803291&r2=803292&view=diff
==============================================================================
--- tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/MarkupConstants.java (original)
+++ tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/MarkupConstants.java Tue Aug 11 20:51:35 2009
@@ -27,7 +27,7 @@
* allowing the click event to occur. Refrences a client-side JavaScript function that displays a standard "wait for
* page to load" modal dialog.
*/
- public static final String WAIT_FOR_PAGE = "javascript:Tapestry.waitForPage(event);";
+ public static final String WAIT_FOR_PAGE = "javascript:return Tapestry.waitForPage(event);";
/**
* Name of attribute for intercepting the user clicking a link.
Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/tapestry.js
URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/tapestry.js?rev=803292&r1=803291&r2=803292&view=diff
==============================================================================
--- tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/tapestry.js (original)
+++ tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/tapestry.js Tue Aug 11 20:51:35 2009
@@ -61,7 +61,7 @@
*/
waitForPage : function(event)
{
- if (Tapestry.pageLoaded) return;
+ if (Tapestry.pageLoaded) return true;
Event.extend(event || window.event).stop();
@@ -107,7 +107,16 @@
// A rare race condition.
if (Tapestry.pageLoaded)
+ {
hideDialog.call(null);
+
+ return true;
+ }
+ else
+ {
+ return false;
+ }
+
},
Re: svn commit: r803292 - in /tapestry/tapestry5/trunk/tapestry-core/src/main:
java/org/apache/tapestry5/MarkupConstants.java resources/org/apache/tapestry5/tapestry.js
Posted by Ted Steen <te...@gmail.com>.
Ah.. Forgot to commit the test!
I'll do it when I get home
2009/8/11 <te...@apache.org>:
> Author: tedst
> Date: Tue Aug 11 20:51:35 2009
> New Revision: 803292
>
> URL: http://svn.apache.org/viewvc?rev=803292&view=rev
> Log:
> TAP5-719: Component LinkSubmit doesn't work
>
> Modified:
> tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/MarkupConstants.java
> tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/tapestry.js
>
> Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/MarkupConstants.java
> URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/MarkupConstants.java?rev=803292&r1=803291&r2=803292&view=diff
> ==============================================================================
> --- tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/MarkupConstants.java (original)
> +++ tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/MarkupConstants.java Tue Aug 11 20:51:35 2009
> @@ -27,7 +27,7 @@
> * allowing the click event to occur. Refrences a client-side JavaScript function that displays a standard "wait for
> * page to load" modal dialog.
> */
> - public static final String WAIT_FOR_PAGE = "javascript:Tapestry.waitForPage(event);";
> + public static final String WAIT_FOR_PAGE = "javascript:return Tapestry.waitForPage(event);";
>
> /**
> * Name of attribute for intercepting the user clicking a link.
>
> Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/tapestry.js
> URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/tapestry.js?rev=803292&r1=803291&r2=803292&view=diff
> ==============================================================================
> --- tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/tapestry.js (original)
> +++ tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/tapestry.js Tue Aug 11 20:51:35 2009
> @@ -61,7 +61,7 @@
> */
> waitForPage : function(event)
> {
> - if (Tapestry.pageLoaded) return;
> + if (Tapestry.pageLoaded) return true;
>
> Event.extend(event || window.event).stop();
>
> @@ -107,7 +107,16 @@
> // A rare race condition.
>
> if (Tapestry.pageLoaded)
> + {
> hideDialog.call(null);
> +
> + return true;
> + }
> + else
> + {
> + return false;
> + }
> +
> },
>
>
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org