You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/11/19 01:48:16 UTC
[GitHub] [tvm] shingjan opened a new pull request, #13441: [Meta Schedule] Patch ICHECK for `target_has_vnni` to avoid seg fault
shingjan opened a new pull request, #13441:
URL: https://github.com/apache/tvm/pull/13441
Previously the ICHECK for `target_has_vnni` would seg fault if this function is not found and no debug info is given. However this patch doesn't fix #13425. Note that the test case added wouldn't fail as the function should already be imported somehow by other imports.
cc: @zxybazh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao commented on a diff in pull request #13441: [Meta Schedule] Patch ICHECK for `target_has_vnni` to avoid seg fault
Posted by GitBox <gi...@apache.org>.
junrushao commented on code in PR #13441:
URL: https://github.com/apache/tvm/pull/13441#discussion_r1027054264
##########
src/meta_schedule/space_generator/space_generator.cc:
##########
@@ -25,7 +25,8 @@ String GetRuleKindFromTarget(const Target& target) {
if (target->kind->name == "llvm") {
static const PackedFunc* f_check_vnni =
runtime::Registry::Get("tvm.topi.x86.utils.target_has_vnni");
- ICHECK(*f_check_vnni != nullptr) << "The `target_has_vnni` func is not in tvm registry.";
+ ICHECK(f_check_vnni != nullptr && *f_check_vnni != nullptr)
+ << "The `target_has_vnni` func is not in tvm registry.";
Review Comment:
```suggestion
ICHECK(f_check_vnni != nullptr) << "The `target_has_vnni` func is not in tvm registry.";
```
##########
tests/python/unittest/test_meta_schedule_space_cpu_winograd.py:
##########
@@ -164,5 +166,106 @@ def cpu_nhwc_0(X: T.Buffer[(1, 14, 14, 128), "float32"], W: T.Buffer[(6, 6, 128,
)
+def test_cpu_target_has_vnni():
Review Comment:
This unittest is not relevant to the crash. Please remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] zxybazh merged pull request #13441: [Meta Schedule] Patch ICHECK for `target_has_vnni` to avoid seg fault
Posted by GitBox <gi...@apache.org>.
zxybazh merged PR #13441:
URL: https://github.com/apache/tvm/pull/13441
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tvm-bot commented on pull request #13441: [Meta Schedule] Patch ICHECK for `target_has_vnni` to avoid seg fault
Posted by GitBox <gi...@apache.org>.
tvm-bot commented on PR #13441:
URL: https://github.com/apache/tvm/pull/13441#issuecomment-1320736533
<!---bot-comment-->
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
<!--bot-comment-ccs-start-->
* No users to tag found in teams: `meta schedule` <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
<sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org