You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by liancheng <gi...@git.apache.org> on 2014/06/17 00:10:47 UTC

[GitHub] spark pull request: Minor fix: made "EXPLAIN" output to play well ...

GitHub user liancheng opened a pull request:

    https://github.com/apache/spark/pull/1097

    Minor fix: made "EXPLAIN" output to play well with JDBC output format

    Fixed the broken JDBC output. Test from Shark `beeline`:
    
    ```
    beeline> !connect jdbc:hive2://localhost:10000/  
    scan complete in 2ms
    Connecting to jdbc:hive2://localhost:10000/
    Enter username for jdbc:hive2://localhost:10000/: lian
    Enter password for jdbc:hive2://localhost:10000/: 
    Connected to: Hive (version 0.12.0)
    Driver: Hive (version 0.12.0)
    Transaction isolation: TRANSACTION_REPEATABLE_READ
    0: jdbc:hive2://localhost:10000/> 
    0: jdbc:hive2://localhost:10000/> explain select * from src;            
    +-------------------------------------------------------------------------------+
    |                                     plan                                      |
    +-------------------------------------------------------------------------------+
    | ExplainCommand [plan#2:0]                                                     |
    |  HiveTableScan [key#0,value#1], (MetastoreRelation default, src, None), None  |
    +-------------------------------------------------------------------------------+
    2 rows selected (1.386 seconds)
    ```

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/liancheng/spark multiLineExplain

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/1097.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1097
    
----
commit eb379677ccb937011b45bb90f819dec9588c2779
Author: Cheng Lian <li...@gmail.com>
Date:   2014-06-16T22:04:56Z

    Made output of "EXPLAIN" play well with JDBC output format

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: Minor fix: made "EXPLAIN" output to play well ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/1097


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: Minor fix: made "EXPLAIN" output to play well ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/1097#issuecomment-46251256
  
    
    Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15825/


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: Minor fix: made "EXPLAIN" output to play well ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/1097#issuecomment-46251255
  
    Merged build finished. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: Minor fix: made "EXPLAIN" output to play well ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/1097#issuecomment-46244984
  
     Merged build triggered. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: Minor fix: made "EXPLAIN" output to play well ...

Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:

    https://github.com/apache/spark/pull/1097#issuecomment-46251700
  
    Thanks. I'm merging this one. The test that failed was a flume test that is sometimes flaky. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: Minor fix: made "EXPLAIN" output to play well ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/1097#issuecomment-46244993
  
    Merged build started. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---