You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by GitBox <gi...@apache.org> on 2022/08/08 04:07:32 UTC
[GitHub] [incubator-pegasus] foreverneverer opened a new pull request, #1106: fix(go-client): scan will not recover when encounter `error_invalid_state`
foreverneverer opened a new pull request, #1106:
URL: https://github.com/apache/incubator-pegasus/pull/1106
### What problem does this PR solve? <!--add issue link with summary if exists-->
https://github.com/apache/incubator-pegasus/issues/903
If rpc's resp = error_invalid_state, go client should support re-config, this feature has support most api but `scan`.
### What is changed and how does it work?
In https://github.com/XiaoMi/pegasus-go-client/pull/86, we add it into `nextBatch`, but miss in `startScanPartition`, this pr add it.
### Checklist <!--REMOVE the items that are not applicable-->
##### Tests <!-- At least one of them must be included. -->
- Unit test
- Integration test
- Manual test (add detailed scripts or steps below)
##### Code changes
- Has interface methods change
##### Related changes
- Need to cherry-pick to the release branch
- Need to update the documentation
- Need to be included in the release note
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] codecov-commenter commented on pull request #1106: fix(go-client): scan will not recover when encounter `error_invalid_state`
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #1106:
URL: https://github.com/apache/incubator-pegasus/pull/1106#issuecomment-1207641622
# [Codecov](https://codecov.io/gh/apache/incubator-pegasus/pull/1106?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`master@b27f101`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #1106 +/- ##
=========================================
Coverage ? 53.19%
=========================================
Files ? 27
Lines ? 2523
Branches ? 0
=========================================
Hits ? 1342
Misses ? 1135
Partials ? 46
```
:mega: Codecov can now indicate which changes are the most critical in Pull Requests. [Learn more](https://about.codecov.io/product/feature/runtime-insights/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] foreverneverer merged pull request #1106: fix(go-client): scan will not recover when encounter `error_invalid_state`
Posted by GitBox <gi...@apache.org>.
foreverneverer merged PR #1106:
URL: https://github.com/apache/incubator-pegasus/pull/1106
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org