[GitHub] [incubator-daffodil] stevedlawrence commented on a change in pull request #310: Add more automation to release candidate container

[GitBox <gi...@apache.org>]

stevedlawrence commented on a change in pull request #310: Add more automation to release candidate container
URL: https://github.com/apache/incubator-daffodil/pull/310#discussion_r362502472
 
 

 ##########
 File path: containers/release-candidate/daffodil-release-candidate
 ##########
 @@ -170,6 +165,8 @@ sbt \
   "daffodil-japi/genjavadoc:doc" \
   "daffodil-sapi/doc" \
 
+echo "Removing old release candidates..."
+svn delete --force $DAFFODIL_DIST_DIR/$VERSION-* 2> /dev/null
 
 Review comment:
   Yeah, I was being a little lazy here. The reason for the /dev/null redirect here is that there won't be an existing release candidate if this is the first one. So svn will output an error that there's nothing to delete. I just wanted to hide that, but you're right that this could potentially hide other real errors.
   
   It's probably a better idea to check for the existence before deleting. I'll make the update.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services