You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Pedro Santos (JIRA)" <ji...@apache.org> on 2011/03/29 14:39:05 UTC
[jira] [Created] (WICKET-3573) Wicket frame example shows empty
frames
Wicket frame example shows empty frames
---------------------------------------
Key: WICKET-3573
URL: https://issues.apache.org/jira/browse/WICKET-3573
Project: Wicket
Issue Type: Bug
Components: wicket-examples
Affects Versions: 1.5-RC3
Environment: Reproduced both in IE and Chrome
Reporter: Pedro Santos
Assignee: Pedro Santos
Simple to reproduce, just open http://localhost:8080/frames/
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-3573) Wicket frame example shows empty
frames
Posted by "Martijn Dashorst (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13014571#comment-13014571 ]
Martijn Dashorst commented on WICKET-3573:
------------------------------------------
I'd rather we deprecate the usage of frames altogether. They're not part of HTML5 as well.
> Wicket frame example shows empty frames
> ---------------------------------------
>
> Key: WICKET-3573
> URL: https://issues.apache.org/jira/browse/WICKET-3573
> Project: Wicket
> Issue Type: Bug
> Components: wicket-examples
> Affects Versions: 1.5-RC3
> Environment: Reproduced both in IE and Chrome
> Reporter: Pedro Santos
> Assignee: Pedro Santos
> Attachments: WICKET-3573.patch
>
>
> Simple to reproduce, just open http://localhost:8080/frames/
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-3573) Wicket frame example shows empty
frames
Posted by "Pedro Santos (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pedro Santos updated WICKET-3573:
---------------------------------
Attachment: WICKET-3573.patch
Frame sources in the wicket examples were hardcoded in the HTML. IMO we were missing a core component for frames, so I'm trying to resolve this ticket introducing the Frame component.
> Wicket frame example shows empty frames
> ---------------------------------------
>
> Key: WICKET-3573
> URL: https://issues.apache.org/jira/browse/WICKET-3573
> Project: Wicket
> Issue Type: Bug
> Components: wicket-examples
> Affects Versions: 1.5-RC3
> Environment: Reproduced both in IE and Chrome
> Reporter: Pedro Santos
> Assignee: Pedro Santos
> Attachments: WICKET-3573.patch
>
>
> Simple to reproduce, just open http://localhost:8080/frames/
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-3573) Wicket frame example shows empty
frames
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13015128#comment-13015128 ]
Martin Grigorov commented on WICKET-3573:
-----------------------------------------
No one needed Frame until now so I think we can live without it.
I vote for ExampleFrame in wicket-examples that will be used just for this example.
> Wicket frame example shows empty frames
> ---------------------------------------
>
> Key: WICKET-3573
> URL: https://issues.apache.org/jira/browse/WICKET-3573
> Project: Wicket
> Issue Type: Bug
> Components: wicket-examples
> Affects Versions: 1.5-RC3
> Environment: Reproduced both in IE and Chrome
> Reporter: Pedro Santos
> Assignee: Pedro Santos
> Attachments: WICKET-3573.patch
>
>
> Simple to reproduce, just open http://localhost:8080/frames/
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-3573) Wicket frame example shows empty
frames
Posted by "Pedro Santos (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13015568#comment-13015568 ]
Pedro Santos commented on WICKET-3573:
--------------------------------------
Fixed with r1088743
As using ExampleFrame component the example are working, we can close this ticket.
About deprecate the usage of frames, we can simple drop everything under org.apache.wicket.examples.frames package. I have no objections.
> Wicket frame example shows empty frames
> ---------------------------------------
>
> Key: WICKET-3573
> URL: https://issues.apache.org/jira/browse/WICKET-3573
> Project: Wicket
> Issue Type: Bug
> Components: wicket-examples
> Affects Versions: 1.5-RC3
> Environment: Reproduced both in IE and Chrome
> Reporter: Pedro Santos
> Assignee: Pedro Santos
> Attachments: WICKET-3573.patch
>
>
> Simple to reproduce, just open http://localhost:8080/frames/
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (WICKET-3573) Wicket frame example shows empty
frames
Posted by "Pedro Santos (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pedro Santos resolved WICKET-3573.
----------------------------------
Resolution: Fixed
Fix Version/s: 1.5-RC4
> Wicket frame example shows empty frames
> ---------------------------------------
>
> Key: WICKET-3573
> URL: https://issues.apache.org/jira/browse/WICKET-3573
> Project: Wicket
> Issue Type: Bug
> Components: wicket-examples
> Affects Versions: 1.5-RC3
> Environment: Reproduced both in IE and Chrome
> Reporter: Pedro Santos
> Assignee: Pedro Santos
> Fix For: 1.5-RC4
>
> Attachments: WICKET-3573.patch
>
>
> Simple to reproduce, just open http://localhost:8080/frames/
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-3573) Wicket frame example shows empty
frames
Posted by "Pedro Santos (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13014894#comment-13014894 ]
Pedro Santos commented on WICKET-3573:
--------------------------------------
What about we remove frames example? Also an option. I will change the patch to use ExampleFrame instead of Frame and commit, after we decide about maintain the example.
> Wicket frame example shows empty frames
> ---------------------------------------
>
> Key: WICKET-3573
> URL: https://issues.apache.org/jira/browse/WICKET-3573
> Project: Wicket
> Issue Type: Bug
> Components: wicket-examples
> Affects Versions: 1.5-RC3
> Environment: Reproduced both in IE and Chrome
> Reporter: Pedro Santos
> Assignee: Pedro Santos
> Attachments: WICKET-3573.patch
>
>
> Simple to reproduce, just open http://localhost:8080/frames/
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira