[GitHub] [madlib] njayaram2 commented on a change in pull request #374: DL: Validate predict input parameters

[GitBox <gi...@apache.org>]

njayaram2 commented on a change in pull request #374: DL: Validate predict input parameters
URL: https://github.com/apache/madlib/pull/374#discussion_r278335598
 
 

 ##########
 File path: src/ports/postgres/modules/deep_learning/madlib_keras_validator.py_in
 ##########
 @@ -53,15 +178,15 @@ class FitInputValidator:
 
     def _validate_input_table(self, table):
         _assert(is_var_valid(table, self.independent_varname),
-                "model_keras error: invalid independent_varname "
-                "('{independent_varname}') for table "
+                "model_keras error: invalid independent_varname "\
 
 Review comment:
   Sure, will change it, I don't feel strongly either way.
   I put it in there since I thought it was clearer to read the code. `\` indicates that I am splitting a single error message across multiple lines in the code (to limit the number of chars showing up in a single line in the python file), although it's still a single line as an error message itself. Python does that implicitly as you pointed out, but I put it there to show it up explicitly in the code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services