You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "waynexia (via GitHub)" <gi...@apache.org> on 2024/09/02 06:57:47 UTC

Re: [PR] feat: add `Allocator` type param to `MutableBuffer` [arrow-rs]

waynexia commented on code in PR #6336:
URL: https://github.com/apache/arrow-rs/pull/6336#discussion_r1740413642


##########
.github/workflows/arrow.yml:
##########
@@ -61,8 +61,8 @@ jobs:
           submodules: true
       - name: Setup Rust toolchain
         uses: ./.github/actions/setup-builder
-      - name: Test arrow-buffer with all features
-        run: cargo test -p arrow-buffer --all-features
+      - name: Test arrow-buffer

Review Comment:
   `arrow-buffer` only has one feature gate `allocator_api` from this PR. This specific change won't affect other tests like `prettyprint` as the command `-p arrow-buffer` only runs on this sub-crate. But I agree it's easy to forget when the new feature comes in the future... Sadly, cargo seems not to support opt-out one feature in CLI 😢 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org