You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by mateiz <gi...@git.apache.org> on 2014/04/03 02:41:21 UTC
[GitHub] spark pull request: SPARK-1093: Annotate developer and experimenta...
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/274#issuecomment-39401280
Hey Patrick, a few comments:
- Should Logging become private[spark]? I think we looked at it before and there was some weird reason why we didn't do it, not sure what.
- The badges unfortunately display weirdly in summary pages. For example look at this one for the root package. The first badge there is actually for Aggregator, but it displays on the bottom of its line, which makes it look like it might belong to the next element.
- It might be good to give these different colors, e.g. something blue for Experimental API.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---