You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/06/02 13:08:12 UTC
[GitHub] [incubator-echarts] plainheart opened a new pull request #12736: feat(markLine): symbolRotate for markLine accepts an array as the parameter to specify symbol rotation at the two endpoints of the mark line.
plainheart opened a new pull request #12736:
URL: https://github.com/apache/incubator-echarts/pull/12736
## Brief Information
This pull request is in the type of:
- [ ] bug fixing
- [x] new feature
- [ ] others
### What does this PR do?
`symbolRotate` for `markLine` accepts an array as the parameter to specify symbol rotation at the two ends of the mark line. I think it may be very helpful in some cases.
### Related issues
- https://github.com/apache/incubator-echarts/pull/12392#issuecomment-611116024
## Details
### Before: What was the problem?
We can not specify different rotations for symbols at the two endpoints of the mark line.
### After: How is it fixed in this PR?
By specifying an array like `[fromSymbolRotation, toSymbolRotation]` for `markLine.symbolRotate`, we can set different rotations for symbols at the two endpoints of the mark line
## Usage
### Are there any API changes?
- [x] The API has been changed.
Added an option `markLine.symbolRotate`, which accepts a number or an array having two numeric elements.
### Related test cases or examples to use the new APIs
Please reder to `test/markLine-symbolRotate.html`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] YiYingWu1302 commented on pull request #12736: feat(markLine): symbolRotate for markLine accepts an array as the parameter to specify symbol rotation at the two endpoints of the mark line.
Posted by GitBox <gi...@apache.org>.
YiYingWu1302 commented on pull request #12736:
URL: https://github.com/apache/incubator-echarts/pull/12736#issuecomment-689259789
Sorry for the very late replay, I suddenly saw this PR and it looks perfect! Thanks again!!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org