[GitHub] [cordova-plugin-geolocation] andreszs opened a new pull request #171: Update plugin.xml

[GitBox <gi...@apache.org>]

andreszs opened a new pull request #171: Update plugin.xml
URL: https://github.com/apache/cordova-plugin-geolocation/pull/171
 
 
   Added ANDROID_GPS_REQUIRED parameter with default value "true".
   The input value will be set in the `android:required=` parameter for the uses-feature rule in the AndroidManifest.xml file.
   Renders #86 and #98 obsolete
   
   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   Android
   
   
   ### Motivation and Context
   Supersedes PR #86 and #98 
   Developer now can specify that the GPS is not mandatory, allowing the app to be distributed in the Store for devices without GPS.
   
   ### Description
   Added ANDROID_GPS_REQUIRED parameter. Possible values are: `true` (default), `false`.
   
   ### Testing
   Added the plugin and tested it on different Android devices, even those without actual GPS. Android Location methods supplant the real GPS just fine and the location method still work properly, but without the accuracy of a real GPS of course.
   
   ### Checklist
   
   - [X] I've run the tests to see all new and existing tests pass
   - [ ] I added automated test coverage as appropriate for this change
   - [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   - [X] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [ ] I've updated the documentation if necessary
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org