You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by "FreeAndNil (via GitHub)" <gi...@apache.org> on 2024/03/17 16:10:55 UTC
[PR] Enable building log4net with docker container #127 (logging-log4net)
FreeAndNil opened a new pull request, #128:
URL: https://github.com/apache/logging-log4net/pull/128
Enable building log4net with docker container #127
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Enable building log4net with docker container #127 (logging-log4net)
Posted by "FreeAndNil (via GitHub)" <gi...@apache.org>.
FreeAndNil commented on PR #128:
URL: https://github.com/apache/logging-log4net/pull/128#issuecomment-2003614301
@vy I've updated the dockerfile, the scripts and https://github.com/apache/logging-log4net/blob/Feature/127-docker-build/doc/BUILDING.md
Please take a look.
@fluffynuts what is your opinion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Enable building log4net with docker container #127 (logging-log4net)
Posted by "FreeAndNil (via GitHub)" <gi...@apache.org>.
FreeAndNil commented on code in PR #128:
URL: https://github.com/apache/logging-log4net/pull/128#discussion_r1530152161
##########
Dockerfile:
##########
@@ -0,0 +1,35 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+
+# http://www.apache.org/licenses/LICENSE-2.0
+
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# MAINTAINER Jan Friedrich
+
+FROM mono:latest
+
+RUN apt-get update \
+ && apt-get upgrade -y \
+ && apt-get install -y wget \
+ && apt-get install -y tree \
+ && wget https://dot.net/v1/dotnet-install.sh -O dotnet-install.sh \
+ && chmod +x ./dotnet-install.sh \
+ && ./dotnet-install.sh --channel 8.0
+ENV DOTNET_NOLOGO=true
+ENV DOTNET_SKIP_FIRST_TIME_EXPERIENCE=true
+ENV DOTNET_ROOT=/root/.dotnet
+ENV PATH="$PATH:$DOTNET_ROOT:$DOTNET_ROOT/tools"
+
+ADD . /logging-log4net
+RUN chmod +x /logging-log4net/docker-build/docker-build.sh
+ADD ./docker-build/.bashrc /root/.bashrc
Review Comment:
You're right. I changed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Enable building log4net with docker container #127 (logging-log4net)
Posted by "FreeAndNil (via GitHub)" <gi...@apache.org>.
FreeAndNil merged PR #128:
URL: https://github.com/apache/logging-log4net/pull/128
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Enable building log4net with docker container #127 (logging-log4net)
Posted by "FreeAndNil (via GitHub)" <gi...@apache.org>.
FreeAndNil commented on code in PR #128:
URL: https://github.com/apache/logging-log4net/pull/128#discussion_r1530151594
##########
package.json:
##########
Review Comment:
Good point. Changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Enable building log4net with docker container #127 (logging-log4net)
Posted by "vy (via GitHub)" <gi...@apache.org>.
vy commented on code in PR #128:
URL: https://github.com/apache/logging-log4net/pull/128#discussion_r1527612300
##########
Dockerfile:
##########
@@ -0,0 +1,35 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+
+# http://www.apache.org/licenses/LICENSE-2.0
+
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# MAINTAINER Jan Friedrich
+
+FROM mono:latest
+
+RUN apt-get update \
+ && apt-get upgrade -y \
+ && apt-get install -y wget \
+ && apt-get install -y tree \
+ && wget https://dot.net/v1/dotnet-install.sh -O dotnet-install.sh \
+ && chmod +x ./dotnet-install.sh \
+ && ./dotnet-install.sh --channel 8.0
+ENV DOTNET_NOLOGO=true
+ENV DOTNET_SKIP_FIRST_TIME_EXPERIENCE=true
+ENV DOTNET_ROOT=/root/.dotnet
+ENV PATH="$PATH:$DOTNET_ROOT:$DOTNET_ROOT/tools"
+
+ADD . /logging-log4net
+
+CMD ["/logging-log4net/docker-build.sh"]
Review Comment:
This doesn't work for me:
```
docker: Error response from daemon: failed to create task for container: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: exec: "/logging-log4net/docker-build.sh": permission denied: unknown.
```
I guess the executable bit is not reflected. I am not gonna Google to try to figure out why, since I know you can do that too. I will appreciate it if you can fix this. In the worst case:
```suggestion
CMD ["sh", "/logging-log4net/docker-build.sh"]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Enable building log4net with docker container #127 (logging-log4net)
Posted by "vy (via GitHub)" <gi...@apache.org>.
vy commented on code in PR #128:
URL: https://github.com/apache/logging-log4net/pull/128#discussion_r1530070505
##########
package.json:
##########
Review Comment:
Doesn't `repository.url` need to be updated in this file?
##########
Dockerfile:
##########
@@ -0,0 +1,35 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+
+# http://www.apache.org/licenses/LICENSE-2.0
+
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# MAINTAINER Jan Friedrich
+
+FROM mono:latest
+
+RUN apt-get update \
+ && apt-get upgrade -y \
+ && apt-get install -y wget \
+ && apt-get install -y tree \
+ && wget https://dot.net/v1/dotnet-install.sh -O dotnet-install.sh \
+ && chmod +x ./dotnet-install.sh \
+ && ./dotnet-install.sh --channel 8.0
+ENV DOTNET_NOLOGO=true
+ENV DOTNET_SKIP_FIRST_TIME_EXPERIENCE=true
+ENV DOTNET_ROOT=/root/.dotnet
+ENV PATH="$PATH:$DOTNET_ROOT:$DOTNET_ROOT/tools"
+
+ADD . /logging-log4net
+RUN chmod +x /logging-log4net/docker-build/docker-build.sh
+ADD ./docker-build/.bashrc /root/.bashrc
Review Comment:
@FreeAndNil, sorry for nit picking, but given the extremely simple contents of `.bashrc` and `docker-build.sh`, I would prefer you remove those files and instead inline their logic here via `CMD` or something similar. The complexity is already mind blowing, let's not bloat it more by introducing extra layers of delegation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Enable building log4net with docker container #127 (logging-log4net)
Posted by "FreeAndNil (via GitHub)" <gi...@apache.org>.
FreeAndNil commented on code in PR #128:
URL: https://github.com/apache/logging-log4net/pull/128#discussion_r1528314444
##########
Dockerfile:
##########
@@ -0,0 +1,35 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+
+# http://www.apache.org/licenses/LICENSE-2.0
+
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# MAINTAINER Jan Friedrich
+
+FROM mono:latest
+
+RUN apt-get update \
+ && apt-get upgrade -y \
+ && apt-get install -y wget \
+ && apt-get install -y tree \
+ && wget https://dot.net/v1/dotnet-install.sh -O dotnet-install.sh \
+ && chmod +x ./dotnet-install.sh \
+ && ./dotnet-install.sh --channel 8.0
+ENV DOTNET_NOLOGO=true
+ENV DOTNET_SKIP_FIRST_TIME_EXPERIENCE=true
+ENV DOTNET_ROOT=/root/.dotnet
+ENV PATH="$PATH:$DOTNET_ROOT:$DOTNET_ROOT/tools"
+
+ADD . /logging-log4net
+
+CMD ["/logging-log4net/docker-build.sh"]
Review Comment:
Thanks for the hint.
The chmod +x was missing.
For whatever reason this worked on my Docker Desktop install.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Enable building log4net with docker container #127 (logging-log4net)
Posted by "fluffynuts (via GitHub)" <gi...@apache.org>.
fluffynuts commented on PR #128:
URL: https://github.com/apache/logging-log4net/pull/128#issuecomment-2003723969
lgtm, tho I'm no docker expert, so as long as it works, which I assume it does (I'm nowhere near a PC rn), then I give it 👍👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org